Test

microsoft · Oct 19, 2023 · 24add2c · 24add2c
1 parent 06bbc1f
commit 24add2c
Show file tree

Hide file tree

Showing 3 changed files with 29 additions and 29 deletions.
diff --git a/code/DeltaKustoLib/CommandModel/Policies/AlterUpdatePolicyCommand.cs b/code/DeltaKustoLib/CommandModel/Policies/AlterUpdatePolicyCommand.cs
@@ -87,7 +87,7 @@ public override string ToScript(ScriptingContext? context)
             var builder = new StringBuilder();
 
             builder.Append(".alter table ");
-            builder.Append(TableName);
+            builder.Append(TableName.ToScript());
             builder.Append(" policy update");
             builder.AppendLine();
             builder.Append("```");

diff --git a/code/DeltaKustoUnitTest/CommandParsing/Policies/AlterIngestionTimePolicyTest.cs b/code/DeltaKustoUnitTest/CommandParsing/Policies/AlterIngestionTimePolicyTest.cs
@@ -21,33 +21,18 @@ public void FunkyTable()
             TestIngestionTimePolicy("['A- 1']");
         }
 
-        [Fact]
-        public void DbComposedTableName()
-        {
-            var command = ParseOneCommand(
-                ".alter table mydb.mytable policy auto_delete"
-                + "@'{\"ExpiryDate\":\"2030-02-01\"}'");
-
-            Assert.IsType<AlterAutoDeletePolicyCommand>(command);
-
-            var realCommand = (AlterAutoDeletePolicyCommand)command;
-
-            Assert.Equal("mytable", realCommand.TableName.Name);
-        }
-
-        [Fact]
-        public void ClusterComposedTableName()
-        {
-            var command = ParseOneCommand(
-                ".alter table mycluster.['my db'].mytable policy auto_delete "
-                + "@'{\"ExpiryDate\":\"2031-02-01\"}'");
-
-            Assert.IsType<AlterAutoDeletePolicyCommand>(command);
-
-            var realCommand = (AlterAutoDeletePolicyCommand)command;
-
-            Assert.Equal("mytable", realCommand.TableName.Name);
-        }
+        //  Currently unsupported in parser
+        //[Fact]
+        //public void DbComposedTableName()
+        //{
+        //    TestIngestionTimePolicy("mydb.mytable");
+        //}
+
+        //[Fact]
+        //public void ClusterComposedTableName()
+        //{
+        //    TestIngestionTimePolicy("mycluster.['my db'].mytable");
+        //}
 
         private void TestIngestionTimePolicy(string tableName)
         {
@@ -57,6 +42,7 @@ private void TestIngestionTimePolicy(string tableName)
 
         private void TestIngestionTimePolicy(string tableName, bool isEnabled)
         {
+            var actualTableName = GetActualTableName(tableName);
             var commandText = $@"
 .alter table {tableName} policy ingestiontime {isEnabled.ToString().ToLower()}";
             var command = ParseOneCommand(commandText);
@@ -65,7 +51,7 @@ private void TestIngestionTimePolicy(string tableName, bool isEnabled)
 
             var realCommand = (AlterIngestionTimePolicyCommand)command;
 
-            Assert.Equal(tableName, realCommand.TableName.Name);
+            Assert.Equal(actualTableName, realCommand.TableName.Name);
             Assert.Equal(isEnabled, realCommand.IsEnabled);
         }
     }

diff --git a/code/DeltaKustoUnitTest/ParsingTestBase.cs b/code/DeltaKustoUnitTest/ParsingTestBase.cs
@@ -30,5 +30,19 @@ protected CommandBase ParseOneCommand(string script)
 
             return commands.First();
         }
+
+        protected static string GetActualTableName(string tableName)
+        {
+            var actualTableName = tableName.Split('.').Last();
+
+            if (actualTableName.StartsWith('['))
+            {
+                return actualTableName.Substring(2, actualTableName.Length - 4);
+            }
+            else
+            {
+                return actualTableName;
+            }
+        }
     }
 }