Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Valid values for IDs are underspecified #40

Closed
int19h opened this issue Mar 29, 2019 · 2 comments
Closed

Valid values for IDs are underspecified #40

int19h opened this issue Mar 29, 2019 · 2 comments
Assignees
Labels
clarification Protocol clarification

Comments

@int19h
Copy link

int19h commented Mar 29, 2019

The spec just says that all IDs are numbers - which is to say, 64-bit floats. It does not say much about how they should be compared, including weird cases like NaN or positive/negative zero, which are seemingly legal.

In practice it seems that protocol clients have much more stringent limitations - for example, VS uses 32-bit integers internally for many IDs, and is unable to cope with any number that doesn't fit. It would be nice to reflect it in the spec itself, limiting the values to some sane subset that all current implementations support in practice (e.g. int32 > 0?).

@weinand weinand self-assigned this Apr 8, 2019
@weinand weinand added the clarification Protocol clarification label Apr 8, 2019
@vadimcn
Copy link
Contributor

vadimcn commented Jul 4, 2019

DAP schema types all IDs as integers, so, clearly, they cannot be fractional numbers. Since VSCode is implemented in javascript, I think the largest integer it can handle is 253 - 1.

@weinand
Copy link
Contributor

weinand commented Nov 22, 2022

see #90

@weinand weinand closed this as completed Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clarification Protocol clarification
Projects
None yet
Development

No branches or pull requests

3 participants