-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
http_client test failing on mac with a segfault. #903
Comments
Does it still repro for you with master? I just merged a fix for a bunch of flaky test problems. |
I will check tonight but I'd say probably yes, from a quick look at your commit, it doesn't seem to touch the files mentioned in the log I posted. |
Right, that's because there were product bugs; the tests were catching legitimate races and memory corruption bugs in cpprestsdk proper. |
Will try them again tonight when I get off work then. |
95409c5 is passing all tests now on macOS 10.14 |
Unfortunately the tests remain a bit flaky because the experimental::asio_http_listener is used to test the client -- and that is full of race conditions and memory corruption bugs :(. The client is the thing we actually care about and I haven't found memory corruption bugs in that yet at least. Since the specific easily reproducable problem is gone I'll close this for now. |
Making a macports portfile, on 2.10.6, testing has following output:
All other tests pass.
Running those tests manually via test_runner, I get this:
The text was updated successfully, but these errors were encountered: