Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added invalid nickname error for conversations #615

Merged
merged 6 commits into from
Feb 22, 2023

Conversation

Jxpxn
Copy link
Contributor

@Jxpxn Jxpxn commented Jan 4, 2023

We currently cannot know if the input nickname is invalid (less than 1 character & more than 50 characters) and if the lib changed it to the default nickname ("Host").

@Jxpxn
Copy link
Contributor Author

Jxpxn commented Jan 4, 2023

@Jxpxn please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.

Contributor License Agreement

@microsoft-github-policy-service agree

@glharper glharper self-requested a review January 19, 2023 16:15
@glharper
Copy link
Member

@Jxpxn Thank you for this PR, I will build and test the changes, with the aim of including this in version 1.26.0 (due early spring)

@glharper
Copy link
Member

Thanks again for this PR. :-)

@glharper glharper merged commit 5076d93 into microsoft:master Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants