-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dotnet-coverage merge
drops hit counts, sets them all to 1
#16
Comments
@AArnott our tooling supports only |
Well, if this is by design, feel free to close. It seems odd that perf reasons come into play during a merge operation. And I'm surprised that tracking a bool is really that much faster than tracking and adding |
We are considering adding possibility to collect number of hits. So let's keep this open and see if more people wants that. You are right that in case of merging this will not make it slower. |
+1 to wanting counts. We use this today to help find "hotspots" where we have duplicate tests (or duplicative test setup) that we can should clean up. |
+1 just run into the same issue 🙄 |
This behaviour is also present when exporting from the Code Coverage Results window |
Description
The
merge
command produces coverage data withhits="1"
hard-coded for all covered lines.Steps to reproduce
I have multiple cobertura coverage reports that I want to use
dotnet-coverage merge
to merge into one.Consider these coverage files:
TestResults.zip
Expected behavior
I expect the merged report to reflect the hit counts for each line.
In particular, the merged product should report that the
{reporoot}\test\Library.Tests\Calculator.cs
file's line 17 was hit 3 times.I get the expected result when merging with the
dotnet-reportgenerator-globaltool
dotnet CLI tool.Actual behavior
Every line reported in the merged .xml file reports
hits="1"
.merged outputs.zip contains outputs from both tools so you can compare.
The text was updated successfully, but these errors were encountered: