Update partitionKey path definitions for cosmosDatabase containers. #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
deployment
crickman
added
PR: in progress
external dependency issue
github-actions
bot
added
webapi
|
is there any table that should be partitioned by user? |
dluc
reviewed
Aug 23, 2023
dluc
reviewed
Aug 23, 2023
TaoChenOSU
reviewed
Aug 23, 2023
dluc
reviewed
Aug 23, 2023
No sir...this model is "chat-centric" |
dluc
reviewed
Aug 23, 2023
|
Another perf detail that came up is the consistency level. The tables are setup for "strong consistency" which could be relaxed to reduce latency. |
dluc
previously approved these changes
Aug 24, 2023
crickman
changed the title
alliscode
previously approved these changes
Aug 28, 2023
alliscode
approved these changes
Aug 28, 2023
teamleader-dev
pushed a commit
to vlink-group/chat-copilot
that referenced
this pull request
Oct 7, 2024
…icrosoft#240) ### Motivation and Context Customer issue reported in microsoft#238 related to partition scheme in cosmosdb containers. ### Description Update partition-key path definition for `ChatMessage`, `ChatPartitipant`, and `MemorySource`. Existing deployments will continue to work in their current mode. CosmosDB containers must be removed and redeployed to realize the peformance update related to the partition scheme. ### Contribution Checklist - [x] The code builds clean without any errors or warnings - [x] The PR follows the [Contribution Guidelines](https://github.com/microsoft/copilot-chat/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/copilot-chat/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Customer issue reported in #238 related to partition scheme in cosmosdb containers.
Description
Update partition-key path definition for
ChatMessage,ChatPartitipant, andMemorySource.Existing deployments will continue to work in their current mode.
CosmosDB containers must be removed and redeployed to realize the peformance update related to the partition scheme.
Contribution Checklist