Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update DialogManager to work with Skills #5792

Closed
4 tasks done
cwhitten opened this issue Mar 26, 2020 · 3 comments
Closed
4 tasks done

Update DialogManager to work with Skills #5792

cwhitten opened this issue Mar 26, 2020 · 3 comments
Labels
Area: Adaptive The issue is related to Adaptive dialogs Area: Skills The issue is related to skills P0 Must Fix. Release-blocker

Comments

@cwhitten
Copy link
Member

cwhitten commented Mar 26, 2020 •
edited by gabog
Loading

In order to enable a Composer-generated bot as a Skill, the DialogManager needs to be updated to support sending an EndOfConversation to signal a Skill exiting. Without this, a Skill created from Composer will be unable to end itself.

Screen Shot 2020-03-25 at 9 07 06 PM

Tracking Status

Dotnet SDK (Tracked in 3657)

  • PR
  • Merged

Javascript SDK (R10, Tracked in 1970)

  • PR
  • Merged

cc @luhan2017 @boydc2014
@clearab clearab transferred this issue from microsoft/botbuilder-dotnet Mar 26, 2020
@clearab clearab added Skills R9 Release 9 - May 15th, 2020 labels Mar 26, 2020
@clearab clearab added the P0 Must Fix. Release-blocker label Mar 26, 2020
@clearab clearab changed the title [Adaptive] [Skills] - Support enabling a Composer-generated bot as a skill [Adaptive] [Skills] - Update DialogManager to support EndOfConversation Mar 26, 2020
@clearab clearab changed the title [Adaptive] [Skills] - Update DialogManager to support EndOfConversation [Adaptive] [Skills] - Update DialogManager to work with Skills Mar 26, 2020
@clearab clearab changed the title [Adaptive] [Skills] - Update DialogManager to work with Skills Update DialogManager to work with Skills Mar 26, 2020
@vishwacsena vishwacsena mentioned this issue Mar 30, 2020
Closed
@vishwacsena
Copy link
Contributor

The only other caveat here is to not send EoC if the bot already sent this.

@vishwacsena
Copy link
Contributor

@gabog per @Stevenic dialogmanager also needs to support OnResumeDialogAsync.

This was referenced Apr 1, 2020
Closed
Closed
@clearab clearab mentioned this issue Apr 3, 2020
Closed
@clearab clearab removed the R9 Release 9 - May 15th, 2020 label Apr 3, 2020
@gabog gabog added Area: Adaptive The issue is related to Adaptive dialogs Area: Skills The issue is related to skills and removed Adaptive labels Aug 12, 2020
@gabog
Copy link
Contributor

gabog commented Aug 13, 2020

dotnet and JS have been updated, closing

@gabog gabog closed this as completed Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area: Adaptive The issue is related to Adaptive dialogs Area: Skills The issue is related to skills P0 Must Fix. Release-blocker
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@clearab @cwhitten @gabog @vishwacsena