Skip to content
This repository has been archived by the owner on Jan 15, 2025. It is now read-only.

chore: recording schema changes to recommendations by UX team #1166

Merged
merged 1 commit into from
Jun 28, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,10 +1,15 @@
{
"$schema": "https://schemas.botframework.com/schemas/component/v1.0/component.schema",
"$role": "implements(Microsoft.IDialog)",
"title": "Pause Recording",
"title": "Recording Pause",
"description": "Pauses recording the current conversation.",
"type": "object",
"additionalProperties": false,
"properties": {
"allowInterruptions": {
"$ref": "schema:#/definitions/booleanExpression",
"title": "Allow Interruptions",
"description": "Allow the dialog to continue when recording pause operation is in progress"
}
}
}
Original file line number Diff line number Diff line change
@@ -1,16 +1,16 @@
{
"$schema": "https://schemas.botframework.com/schemas/ui/v1.0/ui.schema",
"form": {
"label": "Pause Recording",
"subtitle": "Pause Recording",
"label": "Recording Pause",
"subtitle": "Recording Pause",
"order": [
"*"
],
"properties": {
}
},
"menu": {
"label": "Pause Recording",
"label": "Recording Pause",
"submenu": [ "Telephony" ]
}
}
Original file line number Diff line number Diff line change
@@ -1,10 +1,15 @@
{
"$schema": "https://schemas.botframework.com/schemas/component/v1.0/component.schema",
"$role": "implements(Microsoft.IDialog)",
"title": "Resume Recording",
"title": "Recording Resume",
"description": "Resumes recording the current conversation.",
"type": "object",
"additionalProperties": false,
"properties": {
"allowInterruptions": {
"$ref": "schema:#/definitions/booleanExpression",
"title": "Allow Interruptions",
"description": "Allow the dialog to continue when recording resume operation is in progress"
}
}
}
Original file line number Diff line number Diff line change
@@ -1,16 +1,16 @@
{
"$schema": "https://schemas.botframework.com/schemas/ui/v1.0/ui.schema",
"form": {
"label": "Resume Recording",
"subtitle": "Resume Recording",
"label": "Recording Resume",
"subtitle": "Recording Resume",
"order": [
"*"
],
"properties": {
}
},
"menu": {
"label": "Resume Recording",
"label": "Recording Resume",
"submenu": [ "Telephony" ]
}
}
Original file line number Diff line number Diff line change
@@ -1,10 +1,15 @@
{
"$schema": "https://schemas.botframework.com/schemas/component/v1.0/component.schema",
"$role": "implements(Microsoft.IDialog)",
"title": "Start Recording",
"title": "Recording Start",
"description": "Starts recording the current conversation.",
"type": "object",
"additionalProperties": false,
"properties": {
"allowInterruptions": {
"$ref": "schema:#/definitions/booleanExpression",
"title": "Allow Interruptions",
"description": "Allow the dialog to continue when recording start operation is in progress"
}
}
}
Original file line number Diff line number Diff line change
@@ -1,16 +1,16 @@
{
"$schema": "https://schemas.botframework.com/schemas/ui/v1.0/ui.schema",
"form": {
"label": "Start Recording",
"subtitle": "Start Recording",
"label": "Recording Start",
"subtitle": "Recording Start",
"order": [
"*"
],
"properties": {
}
},
"menu": {
"label": "Start Recording",
"label": "Recording Start",
"submenu": [ "Telephony" ]
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -48,10 +48,10 @@
<None Update="Integration\RecordingTests\StartRecording_WithTangent_InterruptionDisabled.test.dialog">
<CopyToOutputDirectory>Always</CopyToOutputDirectory>
</None>
<None Update="Integration\RecordingTests\StartRecording_IgnoredInNonTelephonyChannel.test.dialog">
<None Update="Integration\RecordingTests\Recording_IgnoredInNonTelephonyChannel.test.dialog">
<CopyToOutputDirectory>Always</CopyToOutputDirectory>
</None>
<None Update="Integration\RecordingTests\StartRecording_HappyPath.test.dialog">
<None Update="Integration\RecordingTests\Recording_HappyPath.test.dialog">
<CopyToOutputDirectory>Always</CopyToOutputDirectory>
</None>
</ItemGroup>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ public RecordingTests(ResourceExplorerFixture resourceExplorerFixture) : base(re
}

[Fact]
public async Task StartRecording_HappyPath()
public async Task Recording_HappyPath()
{
await TestUtils.RunTestScript(_resourceExplorerFixture.ResourceExplorer, adapterChannel: Channels.Telephony);
}
Expand Down Expand Up @@ -46,7 +46,7 @@ public async Task StartRecording_CommandResultWrongName()
}

[Fact]
public async Task StartRecording_IgnoredInNonTelephonyChannel()
public async Task Recording_IgnoredInNonTelephonyChannel()
{
await TestUtils.RunTestScript(_resourceExplorerFixture.ResourceExplorer, adapterChannel: Channels.Msteams);
}
Expand Down