Update recording labels per UX feedback (#1166)

Co-authored-by: Pooja Nagpal <[email protected]>
microsoft · Jun 28, 2021 · a2d3fac · a2d3fac
1 parent b6ef2f4
commit a2d3fac
Show file tree

Hide file tree

Showing 10 changed files with 31 additions and 16 deletions.
diff --git a/packages/Telephony/Schemas/Microsoft.Telephony.PauseRecording.schema b/packages/Telephony/Schemas/Microsoft.Telephony.PauseRecording.schema
@@ -1,10 +1,15 @@
 {
   "$schema": "https://schemas.botframework.com/schemas/component/v1.0/component.schema",
   "$role": "implements(Microsoft.IDialog)",
-  "title": "Pause Recording",
+  "title": "Recording Pause",
   "description": "Pauses recording the current conversation.",
   "type": "object",
   "additionalProperties": false,
   "properties": {
+    "allowInterruptions": {
+      "$ref": "schema:#/definitions/booleanExpression",
+      "title": "Allow Interruptions",
+      "description": "Allow the dialog to continue when recording pause operation is in progress"
+    }
   }
 }
diff --git a/packages/Telephony/Schemas/Microsoft.Telephony.PauseRecording.uischema b/packages/Telephony/Schemas/Microsoft.Telephony.PauseRecording.uischema
@@ -1,16 +1,16 @@
 {
   "$schema": "https://schemas.botframework.com/schemas/ui/v1.0/ui.schema",
   "form": {
-    "label": "Pause Recording",
-    "subtitle": "Pause Recording",
+    "label": "Recording Pause",
+    "subtitle": "Recording Pause",
     "order": [
       "*"
     ],
     "properties": {
     }
   },
   "menu": {
-    "label": "Pause Recording",
+    "label": "Recording Pause",
     "submenu": [ "Telephony" ]
   }
 }
diff --git a/packages/Telephony/Schemas/Microsoft.Telephony.ResumeRecording.schema b/packages/Telephony/Schemas/Microsoft.Telephony.ResumeRecording.schema
@@ -1,10 +1,15 @@
 {
   "$schema": "https://schemas.botframework.com/schemas/component/v1.0/component.schema",
   "$role": "implements(Microsoft.IDialog)",
-  "title": "Resume Recording",
+  "title": "Recording Resume",
   "description": "Resumes recording the current conversation.",
   "type": "object",
   "additionalProperties": false,
   "properties": {
+    "allowInterruptions": {
+      "$ref": "schema:#/definitions/booleanExpression",
+      "title": "Allow Interruptions",
+      "description": "Allow the dialog to continue when recording resume operation is in progress"
+    }
   }
 }
diff --git a/packages/Telephony/Schemas/Microsoft.Telephony.ResumeRecording.uischema b/packages/Telephony/Schemas/Microsoft.Telephony.ResumeRecording.uischema
@@ -1,16 +1,16 @@
 {
   "$schema": "https://schemas.botframework.com/schemas/ui/v1.0/ui.schema",
   "form": {
-    "label": "Resume Recording",
-    "subtitle": "Resume Recording",
+    "label": "Recording Resume",
+    "subtitle": "Recording Resume",
     "order": [
       "*"
     ],
     "properties": {
     }
   },
   "menu": {
-    "label": "Resume Recording",
+    "label": "Recording Resume",
     "submenu": [ "Telephony" ]
   }
 }
diff --git a/packages/Telephony/Schemas/Microsoft.Telephony.StartRecording.schema b/packages/Telephony/Schemas/Microsoft.Telephony.StartRecording.schema
@@ -1,10 +1,15 @@
 {
   "$schema": "https://schemas.botframework.com/schemas/component/v1.0/component.schema",
   "$role": "implements(Microsoft.IDialog)",
-  "title": "Start Recording",
+  "title": "Recording Start",
   "description": "Starts recording the current conversation.",
   "type": "object",
   "additionalProperties": false,
   "properties": {
+    "allowInterruptions": {
+      "$ref": "schema:#/definitions/booleanExpression",
+      "title": "Allow Interruptions",
+      "description": "Allow the dialog to continue when recording start operation is in progress"
+    }
   }
 }
diff --git a/packages/Telephony/Schemas/Microsoft.Telephony.StartRecording.uischema b/packages/Telephony/Schemas/Microsoft.Telephony.StartRecording.uischema
@@ -1,16 +1,16 @@
 {
   "$schema": "https://schemas.botframework.com/schemas/ui/v1.0/ui.schema",
   "form": {
-    "label": "Start Recording",
-    "subtitle": "Start Recording",
+    "label": "Recording Start",
+    "subtitle": "Recording Start",
     "order": [
       "*"
     ],
     "properties": {
     }
   },
   "menu": {
-    "label": "Start Recording",
+    "label": "Recording Start",
     "submenu": [ "Telephony" ]
   }
 }
diff --git a/...ests/StartRecording_HappyPath.test.dialog → ...dingTests/Recording_HappyPath.test.dialog b/...ests/StartRecording_HappyPath.test.dialog → ...dingTests/Recording_HappyPath.test.dialog
diff --git a/..._IgnoredInNonTelephonyChannel.test.dialog → ..._IgnoredInNonTelephonyChannel.test.dialog b/..._IgnoredInNonTelephonyChannel.test.dialog → ..._IgnoredInNonTelephonyChannel.test.dialog
diff --git a/.../Microsoft.Bot.Components.Telephony.Tests/Microsoft.Bot.Components.Telephony.Tests.csproj b/.../Microsoft.Bot.Components.Telephony.Tests/Microsoft.Bot.Components.Telephony.Tests.csproj
@@ -48,10 +48,10 @@
     <None Update="Integration\RecordingTests\StartRecording_WithTangent_InterruptionDisabled.test.dialog">
       <CopyToOutputDirectory>Always</CopyToOutputDirectory>
     </None>
-    <None Update="Integration\RecordingTests\StartRecording_IgnoredInNonTelephonyChannel.test.dialog">
+    <None Update="Integration\RecordingTests\Recording_IgnoredInNonTelephonyChannel.test.dialog">
       <CopyToOutputDirectory>Always</CopyToOutputDirectory>
     </None>
-    <None Update="Integration\RecordingTests\StartRecording_HappyPath.test.dialog">
+    <None Update="Integration\RecordingTests\Recording_HappyPath.test.dialog">
       <CopyToOutputDirectory>Always</CopyToOutputDirectory>
     </None>
   </ItemGroup>

diff --git a/tests/packages/Microsoft.Bot.Components.Telephony.Tests/RecordingTests.cs b/tests/packages/Microsoft.Bot.Components.Telephony.Tests/RecordingTests.cs
@@ -17,7 +17,7 @@ public RecordingTests(ResourceExplorerFixture resourceExplorerFixture) : base(re
         }
 
         [Fact]
-        public async Task StartRecording_HappyPath()
+        public async Task Recording_HappyPath()
         {
             await TestUtils.RunTestScript(_resourceExplorerFixture.ResourceExplorer, adapterChannel: Channels.Telephony);
         }
@@ -46,7 +46,7 @@ public async Task StartRecording_CommandResultWrongName()
         }
 
         [Fact]
-        public async Task StartRecording_IgnoredInNonTelephonyChannel()
+        public async Task Recording_IgnoredInNonTelephonyChannel()
         {
             await TestUtils.RunTestScript(_resourceExplorerFixture.ResourceExplorer, adapterChannel: Channels.Msteams);
         }