Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PORT] Additional Language Support for Confirm/Choice Prompts #582

Closed
1 task
tomlm opened this issue Jan 9, 2020 · 1 comment · Fixed by #1557
Closed
1 task

[PORT] Additional Language Support for Confirm/Choice Prompts #582

tomlm opened this issue Jan 9, 2020 · 1 comment · Fixed by #1557
Assignees
Labels
Area: SDK General SDK issues that don't clearly map to other areas (e.g.: helper methods) P1 Painful if we don't fix, won't block releasing Size: L The issue is complex but it is well understood, it will take 4 to 8 days to complete
Milestone

Comments

@tomlm
Copy link
Contributor

tomlm commented Jan 9, 2020

Port this change from botbuilder-dotnet/master branch:
microsoft/botbuilder-dotnet#3129

Recognizers-Text added support for a few additional languages that we don't currently support in our Confirm and Choice prompts:

  • Bulgarian
  • Hindi
  • Italian
  • Korean
  • Swedish
  • Turkish

This PR adds support for those, ensures they get test coverage, and also adds test coverage for PromptCultureModels.

Notes:

  • I skipped adding Arabic support because it is read Right to Left, which makes prompt support tricker.
  • Recognizers-Text JS SDK currently has only added Italian, but I don't believe there's a reason our C#/Node SDKs need to have matching language support
  • I'm also far from a polyglot, so most of the translations were provided by [cough]Google Translate[cough]*

Need to Decide Before Merge

English is really the only language that uses the Oxford/Serial comma. I.e, in this sentence:

Yes, no, or maybe

...the second comma is the Oxford/Serial comma. Most other languages would write it as:

Yes, no or maybe

In our SDK, this is the InlineOrMore property:

public static PromptCultureModel Spanish =>
    new PromptCultureModel
    {
        InlineOr = " o ",
        InlineOrMore = ", o ",
        Locale = Culture.Spanish,
        NoInLanguage = "No",
        Separator = ", ",
        YesInLanguage = "Sí",
    };

..without the Oxford comma, InlineOrMore would look the same as InlineOr.

The languages that I added do not have the Oxford comma (as appropriate). However, many of the current languages we have support for do use the comma in our SDK, although would likely not in real life.

  • Should those commas be removed in the SDK, or would that possibly create backwards-compat issues?
@tracyboehrer tracyboehrer added the R10 Release 10 - August 17th, 2020 label May 11, 2020
@tracyboehrer tracyboehrer added BF Agility and removed BF Agility R10 Release 10 - August 17th, 2020 labels May 21, 2020
@tracyboehrer tracyboehrer added the Area: SDK General SDK issues that don't clearly map to other areas (e.g.: helper methods) label Aug 14, 2020
@tracyboehrer tracyboehrer added the Size: S The issue is simple and well understood, it will take a day or less to complete label Nov 5, 2020
@tracyboehrer tracyboehrer added this to the R12 milestone Nov 5, 2020
@tracyboehrer tracyboehrer added the P1 Painful if we don't fix, won't block releasing label Nov 5, 2020
@mdrichardson mdrichardson added Size: L The issue is complex but it is well understood, it will take 4 to 8 days to complete Size: M The issue is not very complex and it is well understood, it will take 1 to 3 days to complete and removed Size: S The issue is simple and well understood, it will take a day or less to complete Size: L The issue is complex but it is well understood, it will take 4 to 8 days to complete labels Nov 6, 2020
@mdrichardson
Copy link
Contributor

FYI: This is actually a pretty big PR since Python SDK isn't set up with PromptCultureModels like C#/JS

@tracyboehrer tracyboehrer added Size: L The issue is complex but it is well understood, it will take 4 to 8 days to complete and removed Size: M The issue is not very complex and it is well understood, it will take 1 to 3 days to complete labels Feb 1, 2021
@tracyboehrer tracyboehrer modified the milestones: R12, r13 Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: SDK General SDK issues that don't clearly map to other areas (e.g.: helper methods) P1 Painful if we don't fix, won't block releasing Size: L The issue is complex but it is well understood, it will take 4 to 8 days to complete
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants