You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
tomlm opened this issue
Jan 9, 2020
· 1 comment
· Fixed by #1557
Assignees
Labels
Area: SDKGeneral SDK issues that don't clearly map to other areas (e.g.: helper methods)P1Painful if we don't fix, won't block releasingSize: LThe issue is complex but it is well understood, it will take 4 to 8 days to complete
This PR adds support for those, ensures they get test coverage, and also adds test coverage for PromptCultureModels.
Notes:
I skipped adding Arabic support because it is read Right to Left, which makes prompt support tricker.
Recognizers-Text JS SDK currently has only added Italian, but I don't believe there's a reason our C#/Node SDKs need to have matching language support
I'm also far from a polyglot, so most of the translations were provided by [cough]Google Translate[cough]*
Need to Decide Before Merge
English is really the only language that uses the Oxford/Serial comma. I.e, in this sentence:
Yes, no, or maybe
...the second comma is the Oxford/Serial comma. Most other languages would write it as:
Yes, no or maybe
In our SDK, this is the InlineOrMore property:
publicstaticPromptCultureModelSpanish=>newPromptCultureModel{InlineOr=" o ",InlineOrMore=", o ",Locale=Culture.Spanish,NoInLanguage="No",Separator=", ",YesInLanguage="Sí",};
..without the Oxford comma, InlineOrMore would look the same as InlineOr.
The languages that I added do not have the Oxford comma (as appropriate). However, many of the current languages we have support for do use the comma in our SDK, although would likely not in real life.
Should those commas be removed in the SDK, or would that possibly create backwards-compat issues?
The text was updated successfully, but these errors were encountered:
mdrichardson
added
Size: L
The issue is complex but it is well understood, it will take 4 to 8 days to complete
Size: M
The issue is not very complex and it is well understood, it will take 1 to 3 days to complete
and removed
Size: S
The issue is simple and well understood, it will take a day or less to complete
Size: L
The issue is complex but it is well understood, it will take 4 to 8 days to complete
labels
Nov 6, 2020
FYI: This is actually a pretty big PR since Python SDK isn't set up with PromptCultureModels like C#/JS
tracyboehrer
added
Size: L
The issue is complex but it is well understood, it will take 4 to 8 days to complete
and removed
Size: M
The issue is not very complex and it is well understood, it will take 1 to 3 days to complete
labels
Feb 1, 2021
Area: SDKGeneral SDK issues that don't clearly map to other areas (e.g.: helper methods)P1Painful if we don't fix, won't block releasingSize: LThe issue is complex but it is well understood, it will take 4 to 8 days to complete
Recognizers-Text added support for a few additional languages that we don't currently support in our Confirm and Choice prompts:
This PR adds support for those, ensures they get test coverage, and also adds test coverage for
PromptCultureModels
.Notes:
Need to Decide Before Merge
English is really the only language that uses the Oxford/Serial comma. I.e, in this sentence:
...the second comma is the Oxford/Serial comma. Most other languages would write it as:
In our SDK, this is the
InlineOrMore
property:..without the Oxford comma,
InlineOrMore
would look the same asInlineOr
.The languages that I added do not have the Oxford comma (as appropriate). However, many of the current languages we have support for do use the comma in our SDK, although would likely not in real life.
The text was updated successfully, but these errors were encountered: