Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add connect_named_pipe method to CloudAdapter in support of DirectLine Speech #2071

Open
stevkan opened this issue Feb 9, 2024 · 0 comments
Labels
feature-request A request for new functionality or an enhancement to an existing one. needs-triage The issue has just been created and it has not been reviewed by the team.

Comments

@stevkan
Copy link
Collaborator

stevkan commented Feb 9, 2024

Is your feature request related to a problem? Please describe.
When creating a bot that would utilize DirectLine Speech, the current version of the Python SDK does not fully support the use of this service. While much of the infrastructure is in place, the necessary connect_named_pipe method is missing on the CloudAdapter class that would make this service accessible.

Describe the solution you'd like
The connect_named_pipe method needs to be added to the CloudAdapter class located in the cloud_adapter.py file. Using the methods present in the .Net and JS SDKs for reference, it mightlook something like this:

async def connect_named_pipe(
    self, pipe_name: str, bot: Bot, audience: str, callerId: str
):
    streaming_activity_processor = _StreamingActivityProcessor(
        authenticate_request_result=AuthenticateRequestResult(
            audience=audience,
            caller_id=callerId,
            service_url=None,
            connector_factory=ConnectorFactory(
                credentials=MicrosoftAppCredentials(
                    self._AUTH_HEADER_NAME, self._CHANNEL_ID_HEADER_NAME
                ),
                channel_service=None,
            ),
        ),
        adapter=self,
        bot=bot,
    )
    await streaming_activity_processor.connect_named_pipe(pipe_name)

As they would be utilized by the above proposed method, it may be necessary to make updates to the _StreamingActivityProcessor and _StreamingConnectorFactory classes, also located in the cloud_adapter.py file.

@stevkan stevkan added needs-triage The issue has just been created and it has not been reviewed by the team. feature-request A request for new functionality or an enhancement to an existing one. labels Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A request for new functionality or an enhancement to an existing one. needs-triage The issue has just been created and it has not been reviewed by the team.
Projects
None yet
Development

No branches or pull requests

1 participant