Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

O365 card is not properly serialized for Python and Expect replies #1577

Open
denscollo opened this issue Mar 12, 2021 · 0 comments
Open

O365 card is not properly serialized for Python and Expect replies #1577

denscollo opened this issue Mar 12, 2021 · 0 comments
Labels
Area: SDK General SDK issues that don't clearly map to other areas (e.g.: helper methods) Bot Services Required for internal Azure reporting. Do not delete. Do not change color. ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report.

Comments

@denscollo
Copy link
Contributor

Describe the bug

The content of the attachment for the O365 card is not getting properly serialized with the WaterfallSkillBot Python and expect replies delivery mode.

While in Normal mode the content of the attachment is a JSON object, when Expect Replies is set, the content is received as a string.

To Reproduce

Steps to reproduce the behavior:
O365 cards are not supported in Emulator, we can test it using WebChat.

  1. Execute WaterfallHostBot and WaterfallSkillBot Python (link to branch) locally.

  2. Use ngrok to tunnel the WaterfallHost bot port.

  3. Create a Bot Channel Registration in Azure and use ngrok's URL as Messaging Endpoint.

  4. Talk to the bot through WebChat and test the following:
    expectReplies - WaterfallSkill - WATERFALLSKILLBOTPYTHON - Cards - O365

  5. See how the content of the attachment is shown.

Expected behavior

The content should be serialized as JSON.

Screenshots

These images show the attachment sent using Normal and ExpectReplies delivery modes

imagen
@daveta daveta transferred this issue from microsoft/BotFramework-FunctionalTests Mar 17, 2021
@daveta daveta added Bot Services Required for internal Azure reporting. Do not delete. Do not change color. customer-reported Issue is created by anyone that is not a collaborator in the repository. labels Mar 17, 2021
@carlosscastro carlosscastro added ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. and removed customer-reported Issue is created by anyone that is not a collaborator in the repository. labels Mar 22, 2021
@tracyboehrer tracyboehrer added the Area: SDK General SDK issues that don't clearly map to other areas (e.g.: helper methods) label Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area: SDK General SDK issues that don't clearly map to other areas (e.g.: helper methods) Bot Services Required for internal Azure reporting. Do not delete. Do not change color. ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@tracyboehrer @axelsrz @daveta @carlosscastro @denscollo