Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PORT] SkillHandler doesn't return ResourceResponse when forwarding activities #1248

Closed
tomlm opened this issue Jul 13, 2020 · 0 comments · Fixed by #1404
Closed

[PORT] SkillHandler doesn't return ResourceResponse when forwarding activities #1248

tomlm opened this issue Jul 13, 2020 · 0 comments · Fixed by #1404
Assignees
@tracyboehrer
Labels
Area: Skills The issue is related to skills bug Indicates an unexpected problem or an unintended behavior. P1 Painful if we don't fix, won't block releasing Size: M The issue is not very complex and it is well understood, it will take 1 to 3 days to complete
Milestone
R11

Comments

@tomlm
Copy link
Contributor

tomlm commented Jul 13, 2020

Port this change from botbuilder-dotnet/master branch:
microsoft/botbuilder-dotnet#4264

Fixes #4072

(and starts on the end to end test bot consolidation)

Changed projects

  • Microsoft.Bot.Builder
  • Microsoft.Bot.Builder.Tests
  • Skills
@tracyboehrer tracyboehrer added the Area: Skills The issue is related to skills label Aug 14, 2020
@tracyboehrer tracyboehrer changed the title [PORT] Johtaylo/issue4072 [PORT] SkillHandler doesn't return ResourceResponse when forwarding activities Aug 14, 2020
@gabog gabog added bug Indicates an unexpected problem or an unintended behavior. P1 Painful if we don't fix, won't block releasing Size: M The issue is not very complex and it is well understood, it will take 1 to 3 days to complete and removed bug Indicates an unexpected problem or an unintended behavior. labels Sep 10, 2020
@gabog gabog added this to the R11 milestone Sep 10, 2020
@tracyboehrer tracyboehrer mentioned this issue Oct 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tracyboehrer tracyboehrer

Labels
Area: Skills The issue is related to skills bug Indicates an unexpected problem or an unintended behavior. P1 Painful if we don't fix, won't block releasing Size: M The issue is not very complex and it is well understood, it will take 1 to 3 days to complete
Projects
None yet
Milestone
R11
Development

Successfully merging a pull request may close this issue.

SkillHandler doesn't return ResourceResponse when forwarding activities microsoft/botbuilder-python
4 participants
@tracyboehrer @axelsrz @gabog @tomlm