Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PORT] Add EndOfConversationCodes to EndOfConversation activity from Skill #1228

Closed
tomlm opened this issue Jul 7, 2020 · 0 comments · Fixed by #1402
Closed

[PORT] Add EndOfConversationCodes to EndOfConversation activity from Skill #1228

tomlm opened this issue Jul 7, 2020 · 0 comments · Fixed by #1402
Assignees
@tracyboehrer
Labels
Area: Skills The issue is related to skills bug Indicates an unexpected problem or an unintended behavior. P1 Painful if we don't fix, won't block releasing Size: S The issue is simple and well understood, it will take a day or less to complete
Milestone
R11

Comments

@tomlm
Copy link
Contributor

tomlm commented Jul 7, 2020

Port this change from botbuilder-dotnet/master branch:
microsoft/botbuilder-dotnet#4235

Fixes microsoft/botframework-sdk#5852

Changed projects

  • Microsoft.Bot.Builder.Dialogs
  • Microsoft.Bot.Builder.Dialogs.Tests
@tracyboehrer tracyboehrer added Area: Skills The issue is related to skills and removed Skills labels Aug 14, 2020
@gabog gabog added P1 Painful if we don't fix, won't block releasing bug Indicates an unexpected problem or an unintended behavior. labels Sep 11, 2020
@gabog gabog added this to the R11 milestone Sep 11, 2020
@tracyboehrer tracyboehrer added the Size: S The issue is simple and well understood, it will take a day or less to complete label Sep 15, 2020
@tracyboehrer tracyboehrer mentioned this issue Oct 7, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tracyboehrer tracyboehrer

Labels
Area: Skills The issue is related to skills bug Indicates an unexpected problem or an unintended behavior. P1 Painful if we don't fix, won't block releasing Size: S The issue is simple and well understood, it will take a day or less to complete
Projects
None yet
Milestone
R11
Development

Successfully merging a pull request may close this issue.

Add EndOfConversationCodes to EndOfConversation activity from Skill microsoft/botbuilder-python
3 participants
@tracyboehrer @gabog @tomlm