Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PORT] Fix anonymous template name conflict #2583

Closed
tomlm opened this issue Jul 27, 2020 · 0 comments · Fixed by #2595
Closed

[PORT] Fix anonymous template name conflict #2583

tomlm opened this issue Jul 27, 2020 · 0 comments · Fixed by #2595

Comments

@tomlm
Copy link
Contributor

tomlm commented Jul 27, 2020

Port this change from botbuilder-dotnet/master branch:
microsoft/botbuilder-dotnet#4329

Fixes #4328

Description

Currently, LG uses __temp__ as the template id when evaluating inline text with EvaluateText method.
Later, the expandText function was introduced, which would use the evaluateText to achieve the result. So, there would exist two __temp__ templates.

Specific Changes

Assign a random ID for template name when evaluating an inline text to support the nested inline text evaluation.

Changed projects

  • Microsoft.Bot.Builder.LanguageGeneration
  • Microsoft.Bot.Builder.LanguageGeneration.Tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant