Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PORT] properly escape slashes in constant strings with StringExpression/ValueExpression #2443

Closed
tomlm opened this issue Jun 29, 2020 · 1 comment · Fixed by #2660
Closed

[PORT] properly escape slashes in constant strings with StringExpression/ValueExpression #2443

tomlm opened this issue Jun 29, 2020 · 1 comment · Fixed by #2660
Assignees
@feich-ms
Labels
R10 Release 10 - August 17th, 2020

Comments

@tomlm
Copy link
Contributor

tomlm commented Jun 29, 2020

Port this change from botbuilder-dotnet/master branch:
microsoft/botbuilder-dotnet#4194

Fixes #4192

Description

When encoding a string as an expression we need to properly handle slash.

Testing

  • tests updated to validate round-trip slashes

Changed projects

  • AdaptiveExpressions
  • AdaptiveExpressions.Tests
@mrivera-ms mrivera-ms added the R10 Release 10 - August 17th, 2020 label Aug 6, 2020
@mrivera-ms
Copy link
Contributor

Per @boydc2014 , this will be taken for R10.

@boydc2014 boydc2014 assigned Danieladu and feich-ms and unassigned boydc2014 and Danieladu Aug 6, 2020
@feich-ms feich-ms mentioned this issue Aug 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@feich-ms feich-ms

Labels
R10 Release 10 - August 17th, 2020
Projects
None yet
Milestone
No milestone
5 participants
@boydc2014 @Danieladu @tomlm @feich-ms @mrivera-ms