Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webpack fails with botframework-streaming due to Node.js "net" dependency #2224

Closed
stevengum opened this issue May 12, 2020 · 2 comments · Fixed by #2228
Closed

Webpack fails with botframework-streaming due to Node.js "net" dependency #2224

stevengum opened this issue May 12, 2020 · 2 comments · Fixed by #2228
Assignees
Labels
P0 Must Fix. Release-blocker R9 Release 9 - May 15th, 2020
Milestone

Comments

@stevengum
Copy link
Member

Versions

4.9.0

Describe the bug

botframework-streaming/src/utilities/index.ts exports createNodeServer which requires the Node.js 'net' module.

Because Webpack supports require, it attempts to call require('net') and 'net' is not available, so webpack fails.

Potential Fix

A quick fix is removing the export of createNodeServer from the index, and then NamedPipeServer importing directly from the createNodeServer.ts file:

import { createNodeServer } from '../utilities/createNodeServer';

@stevengum
Copy link
Member Author

Reopening because of #2223, there is one more additional step to validate the fix, which is creating a webpack project which imports botframework-directlinejs.

@sgellock
Copy link
Member

A fix for this is going to out in 4.9.1. currently tracking to a 5/27 release date.

@munozemilio munozemilio added this to the R9 milestone Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P0 Must Fix. Release-blocker R9 Release 9 - May 15th, 2020
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants