Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DotNet Parity Expose DialogContext in DialogTestClient #1891

Closed
gabog opened this issue Mar 11, 2020 · 0 comments · Fixed by #1914
Closed

DotNet Parity Expose DialogContext in DialogTestClient #1891

gabog opened this issue Mar 11, 2020 · 0 comments · Fixed by #1914
Assignees
@stevengum
Labels
P1 Painful if we don't fix, won't block releasing R9 Release 9 - May 15th, 2020
Milestone
R9

Comments

@gabog
Copy link
Contributor

gabog commented Mar 11, 2020

The JS DialogTestClient is missing a new property that was added to C# in R8, here are the relevant changes that need to be ported:
https://github.com/microsoft/botbuilder-dotnet/pull/3474/files?file-filters%5B%5D=.cs&file-filters%5B%5D=.csproj#diff-cd997b1a4e0eead2ab97d4306dc01e5d

https://github.com/microsoft/botbuilder-dotnet/pull/3474/files?file-filters%5B%5D=.cs#diff-b9c1f832059ccb96a8441859a274d3b6
@stevengum stevengum self-assigned this Mar 17, 2020
@stevengum stevengum added P1 Painful if we don't fix, won't block releasing parity with C# R9 Release 9 - May 15th, 2020 labels Mar 17, 2020
@stevengum stevengum mentioned this issue Mar 17, 2020
Merged
@munozemilio munozemilio added this to the R9 milestone Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stevengum stevengum

Labels
P1 Painful if we don't fix, won't block releasing R9 Release 9 - May 15th, 2020
Projects
None yet
Milestone
R9
Development

Successfully merging a pull request may close this issue.

port dotnet DialogTestClient DialogContext changes microsoft/botbuilder-js
3 participants
@gabog @stevengum @munozemilio