Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PORT] Add new fields and remove auto-generated text. #1868

Closed
tomlm opened this issue Mar 6, 2020 · 1 comment · Fixed by #1858
Closed

[PORT] Add new fields and remove auto-generated text. #1868

tomlm opened this issue Mar 6, 2020 · 1 comment · Fixed by #1858

Comments

@tomlm
Copy link
Contributor

tomlm commented Mar 6, 2020

Port this change from botbuilder-dotnet/master branch:
microsoft/botbuilder-dotnet#3499

fixes: #3497

Changes:

  • Add ChannelCount and MemberCount to TeamDetails object
  • Remove auto-generated documentation
  • Move file out of the generated folder to make clear this is no longer auto-generated

Changed projects

  • Microsoft.Bot.Schema

[parity with python]
@clearab
Copy link
Contributor

clearab commented Mar 6, 2020

Closing as duplicate.

@clearab clearab closed this as completed Mar 6, 2020
@clearab clearab reopened this Mar 6, 2020
@clearab clearab closed this as completed Mar 6, 2020
@clearab clearab linked a pull request Mar 6, 2020 that will close this issue
add memberCount and channelCount to TeamDetails #1858
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add memberCount and channelCount to TeamDetails microsoft/botbuilder-js
2 participants
@clearab @tomlm