Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make on(... optional on WebRequest #1589

Closed
christopheranderson opened this issue Jan 16, 2020 · 0 comments · Fixed by #1899
Closed

Make on(... optional on WebRequest #1589

christopheranderson opened this issue Jan 16, 2020 · 0 comments · Fixed by #1899
Assignees
Labels
R9 Release 9 - May 15th, 2020
Milestone

Comments

@christopheranderson
Copy link
Contributor

Is your feature request related to a problem? Please describe.

The WebRequest object has on(... as required, but it is largely optional if you can always promise that body is populated before you invoke adapter.processActivity. Because it is required, Azure Functions request object doesn't work, as is, with botbuilder

Describe the solution you'd like

Make on(... optional on WebRequest

Describe alternatives you've considered

I built a shim layer that handles this, but booooo.

Additional context

Trying to make Azure Functions work nicely.

[enhancement]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R9 Release 9 - May 15th, 2020
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants