Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Streaming] Remove watershed dependency from botframework-streaming #1380

Closed
stevengum opened this issue Oct 30, 2019 · 1 comment
Closed

[Streaming] Remove watershed dependency from botframework-streaming #1380

stevengum opened this issue Oct 30, 2019 · 1 comment
Assignees
@stevengum
Labels
P1 Painful if we don't fix, won't block releasing R7 Release 7 - December 10th, 2019
Milestone
R7

Comments

@stevengum
Copy link
Member

stevengum commented Oct 30, 2019 •
edited
Loading

The work for this is being done in branch stgum/wsFactory.

Compared vs 4.6-preview-streaming

Original Message:

Description

  • Remove watershed WebSocket implementation from botframework-streaming
  • Replace default NodeWebSocketFactoryBase class in the BotFrameworkAdapter to use the ws Factory implementation.

Additional context

Instead of using watershed for a default WebSocket implementation, the SDK should use a more actively maintained, popular and therefore current WebSocket library, such as ws.

The watershed library is not one of the commonly used libraries for a Websocket implementation in the Node.js community.

It is not being actively maintained, and its last minor release (0.4.0) was released almost 2 years ago (November 21, 2017):

image
@stevengum stevengum added P1 Painful if we don't fix, won't block releasing R7 Release 7 - December 10th, 2019 Streaming Extensions labels Oct 30, 2019
@stevengum stevengum self-assigned this Oct 30, 2019
@stevengum stevengum mentioned this issue Nov 17, 2019
Merged
@stevengum
Copy link
Member Author

Closing via #1425.

@munozemilio munozemilio added this to the R7 milestone Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stevengum stevengum

Labels
P1 Painful if we don't fix, won't block releasing R7 Release 7 - December 10th, 2019
Projects
None yet
Milestone
R7
Development

No branches or pull requests
2 participants
@stevengum @munozemilio