New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure Activity.Id is empty before sending #1340

Closed

EricDahlvang opened this issue Oct 21, 2019 · 0 comments · Fixed by #1344

Member

EricDahlvang commented Oct 21, 2019 •

edited

Loading

Describe the bug

We are currently sending Activity.Ids IF the user has provided one in the Activity. The spec states:

A2031: Clients and bots SHOULD NOT include an id field in activities they generate.

ref: https://github.com/microsoft/botframework-sdk/blob/master/specs/botframework-activity/botframework-activity.md#id

ideal fix also change .js to add ResourceResponse.Id to activity after sent (if present, of course)

[bug]

EricDahlvang mentioned this issue

add random to transcript generated ids and set sent activity.id #1344

Merged

EricDahlvang closed this as completed in #1344

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment