Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to checkout action v2.2.0 #10939

Merged
merged 1 commit into from
Jun 16, 2020
Merged

Conversation

Charles-Gagnon
Copy link
Contributor

This should fix the issue we've been seeing with the coverage upload failing. See coverallsapp/github-action#55 for some more information - but in short v1 of the action was just pulling the latest all the time. v2.2.0 was changed to pull the commit specified by GITHUB_SHA which is what coveralls uses for the upload and so should ensure that the specified commit always exists.

I updated all the action versions for consistency - we really only need to update the ci ones but it's best to keep things consistent when we can.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 35.232% when pulling 298ff86 on chgagnon/updateCheckout into f13a595 on main.

@Charles-Gagnon Charles-Gagnon merged commit ad5c697 into main Jun 16, 2020
@Charles-Gagnon Charles-Gagnon deleted the chgagnon/updateCheckout branch June 16, 2020 18:31
ktech99 pushed a commit that referenced this pull request Aug 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants