Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trust Server Cert dropdown not hidden for Strict Encryption #25378

Closed
cheenamalhotra opened this issue Feb 22, 2024 · 3 comments · Fixed by #25384
Closed

Trust Server Cert dropdown not hidden for Strict Encryption #25378

cheenamalhotra opened this issue Feb 22, 2024 · 3 comments · Fixed by #25384
Assignees
@cheenamalhotra
Labels
Approved Area - Connection Bug Triage: Done
Milestone
February 2024 Rel...

Comments

@cheenamalhotra
Copy link
Member

  • Azure Data Studio Version: 1.48.0-rc1, Insiders
  • OS Version: Windows 11

Selecting Strict encryption should hide the Trust Server Certificate control as it does until 1.47.1

Screenshot 2024-02-22 at 8 07 23 PM
@cheenamalhotra cheenamalhotra added this to the February 2024 Release milestone Feb 22, 2024
@cheenamalhotra cheenamalhotra self-assigned this Feb 22, 2024
@kisantia
Copy link
Contributor

probably related to this change I made #25311

@cheenamalhotra cheenamalhotra mentioned this issue Feb 22, 2024
Merged
@cheenamalhotra
Copy link
Member Author

Yeah, we were supposed to match the 'values' but unfortunately selection event only provides display value. Too late to change that now, but I have a fix to use widget's current value when event is triggered, which provides correct value.

@kisantia kisantia linked a pull request Feb 22, 2024 that will close this issue
[Port] Fix custom options selection event (#25380) #25384
Merged
@cheenamalhotra cheenamalhotra mentioned this issue Feb 22, 2024
Merged
@kisantia
Copy link
Contributor

Validated this is now fixed in the latest RC build

@github-project-automation github-project-automation bot moved this from Needs triage to Done in ADS Core Committer and Fundamentals Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cheenamalhotra cheenamalhotra

Labels
Approved Area - Connection Bug Triage: Done
Projects
No open projects
ADS Core Committer and Fundamentals
Status: Done
Milestone
February 2024 Release
Development

Successfully merging a pull request may close this issue.

[Port] Fix custom options selection event (#25380) microsoft/azuredatastudio
2 participants
@cheenamalhotra @kisantia