Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server Reports Top 10 DB Space Usage does not work on case sensitive instance #2003

Closed
LitKnd opened this issue Jul 24, 2018 · 5 comments
Closed

Comments

@LitKnd
Copy link

LitKnd commented Jul 24, 2018

  • SQL Operations Studio Version: 0.31.4 (mac)
  • Server Reports version: 0.1.2

Steps to Reproduce:

  • Install Server Report extension on an instance using case sensitive collation, then open the tab.
  • The 'Top 10 DBA Space Usage' graph will be blank, instead of showing data.
  • Click ...'Run Query'
  • The query will fail with multiple errors:

Msg 2812, Level 16, State 62, Line 10 Could not find stored procedure 'sp_msforeachdb'. Msg 2812, Level 16, State 62, Line 25 Could not find stored procedure 'sp_msforeachdb'. Msg 2812, Level 16, State 62, Line 39 Could not find stored procedure 'sp_msforeachdb'.

Thoughts on fixing this:

  • The proper case of this built in procedure is: sp_MSforeachdb. A quick fix would be to fix the case of the statement.
  • This built in procedure is officially unsupported and has been found to be unreliable by many users, so a longer term fix would be to use a different mechanism to loop between the databases. (Example post talking about the problems by Aaron Bertrand is here.)

case sensitive instance bug

@yualan
Copy link
Contributor

yualan commented Jul 25, 2018

Hi @LitKnd, thanks for bringing this up and the nice gif.

It looks like @vickyharp opened this same issue: #1799 She also suggested the same change.

I can check with engineering team to see if we can make an update. In the short-term, we can make this fix, but long term we can discuss a better approach.

@LitKnd
Copy link
Author

LitKnd commented Jul 25, 2018

Thanks! Just realized I was only searching for open issues, so I missed it.

@LitKnd LitKnd closed this as completed Jul 25, 2018
@LitKnd LitKnd reopened this Jul 25, 2018
@llali llali self-assigned this Jul 25, 2018
@kburtram
Copy link
Member

I think this should already be fixed. I'll push an extension update later today.

@kburtram kburtram assigned kburtram and llali and unassigned llali Jul 27, 2018
@kburtram kburtram added this to the August Public Preview milestone Jul 27, 2018
@kburtram
Copy link
Member

kburtram commented Aug 1, 2018

I published Server Reports 0.1.3 which should fix this. Please reactive if this problem persists with the latest extension. Thanks for reporting!

@kburtram kburtram closed this as completed Aug 1, 2018
@LitKnd
Copy link
Author

LitKnd commented Aug 1, 2018

Yes, it's beautiful now! Thanks.

@adsbot adsbot bot locked and limited conversation to collaborators Mar 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants