From 314493da44eb99e2c701b26478103f79bd5460a9 Mon Sep 17 00:00:00 2001 From: Ritik Kumar Date: Thu, 5 Oct 2023 15:54:20 +0530 Subject: [PATCH] updated editSkuRecommendationParam button to open dialog (#24598) --- .../wizard/skuRecommendation/skuDataCollectionToolbar.ts | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/extensions/sql-migration/src/wizard/skuRecommendation/skuDataCollectionToolbar.ts b/extensions/sql-migration/src/wizard/skuRecommendation/skuDataCollectionToolbar.ts index 41f2dacc2777..3332e0b222b7 100644 --- a/extensions/sql-migration/src/wizard/skuRecommendation/skuDataCollectionToolbar.ts +++ b/extensions/sql-migration/src/wizard/skuRecommendation/skuDataCollectionToolbar.ts @@ -17,6 +17,7 @@ import * as constants from '../../constants/strings'; import { MigrationStateModel, PerformanceDataSourceOptions } from '../../models/stateMachine'; import { SKURecommendationPage } from './skuRecommendationPage'; import { ImportPerformanceDataDialog } from '../../dialog/skuRecommendationResults/importPerformanceDataDialog'; +import { SkuEditParametersDialog } from '../../dialog/skuRecommendationResults/skuEditParametersDialog'; // TODO - "Change this to actual default path once it is available" const DEFAULT_PATH_FOR_START_DATA_COLLECTION = "C:\DataPointsCollectionFolder"; @@ -195,7 +196,11 @@ export class SkuDataCollectionToolbar implements vscode.Disposable { ...styles.TOOLBAR_CSS } }).component(); - // TODO - implement onDidClick and add to disposables + + let skuEditParametersDialog = new SkuEditParametersDialog(this.skuRecommendationPage, this.migrationStateModel); + this._disposables.push( + recommendationParametersButton.onDidClick( + async () => await skuEditParametersDialog.openDialog())); return recommendationParametersButton; }