Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Functions Plugin: Make FUNCTIONS_WORKER_RUNTIME set for java by default #400

Closed
brunoborges opened this issue Sep 21, 2018 · 7 comments
Closed

Comments

@brunoborges
Copy link
Member

Plugin name and version

The property FUNCTIONS_WORKER_RUNTIME should not be required as explicitly set property, since this is a Maven plugin for Java functions.

Plugin configuration in your pom.xml

            <plugin>
                <groupId>com.microsoft.azure</groupId>
                <artifactId>azure-functions-maven-plugin</artifactId>
                <configuration>
                    <resourceGroup>myResourceGroup</resourceGroup>
                    <appName>myfuncapp</appName>
                    <appSettings>
                        <property>
                            <name>FUNCTIONS_EXTENSION_VERSION</name>
                            <value>beta</value>
                        </property>
                        <property>
                            <name>FUNCTIONS_WORKER_RUNTIME</name>
                            <value>java</value>
                        </property>
                    </appSettings>
                </configuration>
                <executions>
                    <execution>
                        <id>package-functions</id>
                        <goals>
                            <goal>package</goal>
                        </goals>
                    </execution>
                </executions>
            </plugin>
@brunoborges
Copy link
Member Author

Ensure that the archetype does not have this property explicitly set in the template.

microsoft/azure-maven-archetypes#71

@jdneo
Copy link
Member

jdneo commented Sep 22, 2018

@pragnagopa any thoughts?

@pragnagopa
Copy link
Member

Makes sense. Can we set this as part of deployment?

@jdneo
Copy link
Member

jdneo commented Sep 25, 2018

@brunoborges @pragnagopa

Do you mean we need to add this setting implicitly during the deployment instead of setting it explicitly in the plugin configuration?

If our goal is to simplify the configuration, besides remove it in the archetype, I think one way we could do is to check the setting during deployment:

  • If this setting is not set, adding it
  • If this setting is set and is set to java, we are good
  • If this setting is set but not java, we show a warning

Meanwhile, we need to output messages to make sure the deployment will be as transparent as possible

@Flanker32
Copy link
Member

Done in #653

@Ferrarilambo1020
Copy link

Ensure that the archetype does not have this property explicitly set in the template.

microsoft/azure-maven-archetypes#71

[email protected]

@Ferrarilambo1020
Copy link

__

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants