From 6a70d957d7ec16d4a66ef49ff2d7364c08fd98b4 Mon Sep 17 00:00:00 2001 From: Ruslan Urmeev Date: Fri, 20 Dec 2019 16:01:46 +0400 Subject: [PATCH 1/8] rename appcenter podspec to appcenter-rn to avoid conflicts --- appcenter/ios/{appcenter.podspec => appcenter-rn.podspec} | 2 +- appcenter/react-native.config.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) rename appcenter/ios/{appcenter.podspec => appcenter-rn.podspec} (95%) diff --git a/appcenter/ios/appcenter.podspec b/appcenter/ios/appcenter-rn.podspec similarity index 95% rename from appcenter/ios/appcenter.podspec rename to appcenter/ios/appcenter-rn.podspec index b021eccc4..58a4117ba 100644 --- a/appcenter/ios/appcenter.podspec +++ b/appcenter/ios/appcenter-rn.podspec @@ -3,7 +3,7 @@ require 'json' package = JSON.parse(File.read(File.join(__dir__, '../package.json'))) Pod::Spec.new do |s| - s.name = package['name'] + s.name = 'appcenter-rn' s.version = package['version'] s.summary = package['description'] s.license = package['license'] diff --git a/appcenter/react-native.config.js b/appcenter/react-native.config.js index 4131f5401..18c56ac3f 100644 --- a/appcenter/react-native.config.js +++ b/appcenter/react-native.config.js @@ -4,7 +4,7 @@ module.exports = { dependency: { platforms: { ios: { - podspecPath: path.join(__dirname, 'ios', 'appcenter.podspec') + podspecPath: path.join(__dirname, 'ios', 'appcenter-rn.podspec') }, android: { packageInstance: 'new AppCenterReactNativePackage(getApplication())' From d6890d151dbfd7ecf5779a045fc0cc22cc196fbb Mon Sep 17 00:00:00 2001 From: Ruslan Urmeev Date: Fri, 20 Dec 2019 20:55:45 +0400 Subject: [PATCH 2/8] update changelog --- CHANGELOG.md | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 08c4f6ec8..77a3e76f4 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,15 @@ # App Center SDK for React Native Change Log +## Version 2.6.2 (Under development) + +### App Center + +#### iOS + +* **[Fix]** Fix an error where Cocoapods couldn't find appcenter.podspec.json file. + +___ + ## Version 2.6.1 ### App Center From 0b3fdf2a69c4d81ce7111f341c2b2e6fbcc214e3 Mon Sep 17 00:00:00 2001 From: Ruslan Urmeev Date: Mon, 23 Dec 2019 13:30:47 +0400 Subject: [PATCH 3/8] Apply suggestions from code review Co-Authored-By: Guillaume Perrot --- appcenter/ios/appcenter-rn.podspec | 2 +- appcenter/react-native.config.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/appcenter/ios/appcenter-rn.podspec b/appcenter/ios/appcenter-rn.podspec index 58a4117ba..109a738b0 100644 --- a/appcenter/ios/appcenter-rn.podspec +++ b/appcenter/ios/appcenter-rn.podspec @@ -3,7 +3,7 @@ require 'json' package = JSON.parse(File.read(File.join(__dir__, '../package.json'))) Pod::Spec.new do |s| - s.name = 'appcenter-rn' + s.name = 'appcenter-core' s.version = package['version'] s.summary = package['description'] s.license = package['license'] diff --git a/appcenter/react-native.config.js b/appcenter/react-native.config.js index 18c56ac3f..9d40c82a9 100644 --- a/appcenter/react-native.config.js +++ b/appcenter/react-native.config.js @@ -4,7 +4,7 @@ module.exports = { dependency: { platforms: { ios: { - podspecPath: path.join(__dirname, 'ios', 'appcenter-rn.podspec') + podspecPath: path.join(__dirname, 'ios', 'appcenter-core.podspec') }, android: { packageInstance: 'new AppCenterReactNativePackage(getApplication())' From 648127375ca337c3a6fd8845f37151b701bc9750 Mon Sep 17 00:00:00 2001 From: Ruslan Urmeev Date: Mon, 23 Dec 2019 14:04:19 +0400 Subject: [PATCH 4/8] appcenter-core podspec --- appcenter/ios/{appcenter-rn.podspec => appcenter-core.podspec} | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename appcenter/ios/{appcenter-rn.podspec => appcenter-core.podspec} (100%) diff --git a/appcenter/ios/appcenter-rn.podspec b/appcenter/ios/appcenter-core.podspec similarity index 100% rename from appcenter/ios/appcenter-rn.podspec rename to appcenter/ios/appcenter-core.podspec From 51962e305e3fa6a3a9e76c5a06015ff7b09a1876 Mon Sep 17 00:00:00 2001 From: Anna Kocheshkova Date: Tue, 24 Dec 2019 14:14:55 +0300 Subject: [PATCH 5/8] Add s.static_framework = true --- appcenter-analytics/ios/appcenter-analytics.podspec | 1 + appcenter-auth/ios/appcenter-auth.podspec | 1 + appcenter-crashes/ios/appcenter-crashes.podspec | 1 + appcenter-data/ios/appcenter-data.podspec | 1 + appcenter-push/ios/appcenter-push.podspec | 1 + appcenter/ios/appcenter-core.podspec | 1 + 6 files changed, 6 insertions(+) diff --git a/appcenter-analytics/ios/appcenter-analytics.podspec b/appcenter-analytics/ios/appcenter-analytics.podspec index d5dde6f71..9aa80e514 100644 --- a/appcenter-analytics/ios/appcenter-analytics.podspec +++ b/appcenter-analytics/ios/appcenter-analytics.podspec @@ -21,4 +21,5 @@ Pod::Spec.new do |s| s.dependency 'AppCenterReactNativeShared' s.dependency 'AppCenter/Analytics' s.dependency 'React' + s.static_framework = true end diff --git a/appcenter-auth/ios/appcenter-auth.podspec b/appcenter-auth/ios/appcenter-auth.podspec index 4200895db..95c8d9191 100644 --- a/appcenter-auth/ios/appcenter-auth.podspec +++ b/appcenter-auth/ios/appcenter-auth.podspec @@ -21,4 +21,5 @@ Pod::Spec.new do |s| s.dependency 'AppCenterReactNativeShared' s.dependency 'AppCenter/Auth' s.dependency 'React' + s.static_framework = true end diff --git a/appcenter-crashes/ios/appcenter-crashes.podspec b/appcenter-crashes/ios/appcenter-crashes.podspec index 2b77bdd8a..f67ebb1cd 100644 --- a/appcenter-crashes/ios/appcenter-crashes.podspec +++ b/appcenter-crashes/ios/appcenter-crashes.podspec @@ -22,4 +22,5 @@ Pod::Spec.new do |s| s.dependency 'AppCenterReactNativeShared' s.dependency 'AppCenter/Crashes' s.dependency 'React' + s.static_framework = true end diff --git a/appcenter-data/ios/appcenter-data.podspec b/appcenter-data/ios/appcenter-data.podspec index 9ba3b04c9..77e5c8b96 100644 --- a/appcenter-data/ios/appcenter-data.podspec +++ b/appcenter-data/ios/appcenter-data.podspec @@ -21,4 +21,5 @@ Pod::Spec.new do |s| s.dependency 'AppCenterReactNativeShared' s.dependency 'AppCenter/Data' s.dependency 'React' + s.static_framework = true end diff --git a/appcenter-push/ios/appcenter-push.podspec b/appcenter-push/ios/appcenter-push.podspec index 1b114c6e1..abaf8ae95 100644 --- a/appcenter-push/ios/appcenter-push.podspec +++ b/appcenter-push/ios/appcenter-push.podspec @@ -22,4 +22,5 @@ Pod::Spec.new do |s| s.dependency 'AppCenterReactNativeShared' s.dependency 'AppCenter/Push' s.dependency 'React' + s.static_framework = true end diff --git a/appcenter/ios/appcenter-core.podspec b/appcenter/ios/appcenter-core.podspec index 109a738b0..dd888e6cf 100644 --- a/appcenter/ios/appcenter-core.podspec +++ b/appcenter/ios/appcenter-core.podspec @@ -20,4 +20,5 @@ Pod::Spec.new do |s| s.vendored_frameworks = 'AppCenterReactNativeShared/AppCenterReactNativeShared.framework' s.dependency 'AppCenterReactNativeShared' s.dependency 'React' + s.static_framework = true end From 4678601eab476d5fd3a89255c83fc430c6f614e9 Mon Sep 17 00:00:00 2001 From: Anna Kocheshkova Date: Tue, 24 Dec 2019 15:53:08 +0300 Subject: [PATCH 6/8] Rephrase changelog --- CHANGELOG.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 77a3e76f4..03e82449c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,7 +6,8 @@ #### iOS -* **[Fix]** Fix an error where Cocoapods couldn't find appcenter.podspec.json file. +* **[Fix]** Fix an error where **appcenter.podspec.json** could not be found. +* **[Fix]** Fix issues with `use_frameworks!` directive. ___ From 35939646e32abe25166f681739010ce7c0a53ef8 Mon Sep 17 00:00:00 2001 From: Ruslan Urmeev Date: Wed, 8 Jan 2020 13:27:34 +0400 Subject: [PATCH 7/8] Update CHANGELOG.md Co-Authored-By: Di Hei --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 03e82449c..6a6830c72 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,7 +6,7 @@ #### iOS -* **[Fix]** Fix an error where **appcenter.podspec.json** could not be found. +* **[Fix]** Fix an error where **appcenter.podspec.json** could not be found when using CocoaPods version 1.8.x. * **[Fix]** Fix issues with `use_frameworks!` directive. ___ From c2118091211a67200307a5adc9b9e6ef4b12769b Mon Sep 17 00:00:00 2001 From: Ruslan Urmeev Date: Wed, 8 Jan 2020 13:33:07 +0400 Subject: [PATCH 8/8] comment appcenter-core.podspec --- appcenter/ios/appcenter-core.podspec | 2 ++ 1 file changed, 2 insertions(+) diff --git a/appcenter/ios/appcenter-core.podspec b/appcenter/ios/appcenter-core.podspec index dd888e6cf..855d6e9bf 100644 --- a/appcenter/ios/appcenter-core.podspec +++ b/appcenter/ios/appcenter-core.podspec @@ -3,6 +3,8 @@ require 'json' package = JSON.parse(File.read(File.join(__dir__, '../package.json'))) Pod::Spec.new do |s| + # The name is hardcoded due to a name conflict, resulting in the error 'Errno::ENOENT - No such file or directory @ rb_sysopen - appcenter.podspec.json' error. + # See https://github.com/microsoft/appcenter-sdk-react-native/issues/760 s.name = 'appcenter-core' s.version = package['version'] s.summary = package['description']