-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps-dev): bump @types/jest from 25.2.1 to 25.2.2 #123
Merged
dependabot-preview
merged 1 commit into
master
from
dependabot/npm_and_yarn/types/jest-25.2.2
May 14, 2020
Merged
chore(deps-dev): bump @types/jest from 25.2.1 to 25.2.2 #123
dependabot-preview
merged 1 commit into
master
from
dependabot/npm_and_yarn/types/jest-25.2.2
May 14, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [@types/jest](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/jest) from 25.2.1 to 25.2.2. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/jest) Signed-off-by: dependabot-preview[bot] <[email protected]>
dependabot-preview
bot
added
category: engineering
dependencies
Pull requests that update a dependency file
labels
May 14, 2020
dbjorge
approved these changes
May 14, 2020
dependabot-preview
bot
deleted the
dependabot/npm_and_yarn/types/jest-25.2.2
branch
May 14, 2020 17:40
adsathye
added a commit
that referenced
this pull request
Oct 21, 2022
'yarn act' did not work for me. Running only 'act' worked! #### Details <!-- Usually a sentence or two describing what the PR changes --> ##### Motivation <!-- This can be as simple as "addresses issue #123" --> ##### Context <!-- Are there any parts that you've intentionally left out-of-scope for a later PR to handle? --> <!-- Were there any alternative approaches you considered? What tradeoffs did you consider? --> #### Pull request checklist <!-- If a checklist item is not applicable to this change, write "n/a" in the checkbox --> - [ ] Addresses an existing issue: Fixes #0000 - [ ] Added relevant unit test for your changes. (`yarn test`) - [ ] Verified code coverage for the changes made. Check coverage report at: `<rootDir>/test-results/unit/coverage` - [ ] Ran precheckin (`yarn precheckin`) - [ ] Described how this PR impacts both the ADO extension and the GitHub action
katydecorah
added a commit
that referenced
this pull request
Oct 31, 2022
#### Details The browser resolution set by ai-scan is 800x600, this pull request updates the set `scanResultData.browserResolution` to match. This value is printed at the bottom of reports. This pull request will also add a bullet point to each usage document to specify the viewport size. ![The screenshot is the footnote shown at the bottom of AI scans. It reads "with a display resolution of 1920x1080" when it should say "with a display resolution of 800x600"](https://user-images.githubusercontent.com/2180540/199054241-1b93501c-a418-44b3-9e58-08e50fadcfd3.png) ##### Motivation <!-- This can be as simple as "addresses issue #123" --> ##### Context <!-- Are there any parts that you've intentionally left out-of-scope for a later PR to handle? --> Is there a way to pull this from the ai-scan to prevent future mismatches? It doesn't look likely. This is something we should consider if we decide to create viewport inputs. <!-- Were there any alternative approaches you considered? What tradeoffs did you consider? --> #### Pull request checklist <!-- If a checklist item is not applicable to this change, write "n/a" in the checkbox --> - [x] Addresses an existing issue: Fixes #0000 - [x] Added relevant unit test for your changes. (`yarn test`) - [x] Verified code coverage for the changes made. Check coverage report at: `<rootDir>/test-results/unit/coverage` - [x] Ran precheckin (`yarn precheckin`) - [x] Described how this PR impacts both the ADO extension and the GitHub action
katydecorah
added a commit
that referenced
this pull request
Nov 15, 2022
…n pipeline (#1388) #### Details In #1371 we added documentation links to the pipeline. I noticed that the trailing period in `helpMarkdown` caused the last URL to become malformed (link text: "how to setup authentication"). This PR will remove the period. I pushed this branch to a staging extension. You can validate the working links on line 7 in the following build: https://dev.azure.com/accessibility-insights-private/Accessibility%20Insights%20(private)/_build/results?buildId=39206&view=logs&j=12f1170f-54f2-53f3-20dd-22fc7dff55f9&t=7384d774-f7ca-599c-ee57-ab2c05be9247&l=7 This change only impact the extension. ##### Motivation <!-- This can be as simple as "addresses issue #123" --> ##### Context <!-- Are there any parts that you've intentionally left out-of-scope for a later PR to handle? --> <!-- Were there any alternative approaches you considered? What tradeoffs did you consider? --> #### Pull request checklist <!-- If a checklist item is not applicable to this change, write "n/a" in the checkbox --> - [n/a] Addresses an existing issue: Fixes #0000 - [n/a] Added relevant unit test for your changes. (`yarn test`) - [n/a] Verified code coverage for the changes made. Check coverage report at: `<rootDir>/test-results/unit/coverage` - [x] Ran precheckin (`yarn precheckin`) - [x] Described how this PR impacts both the ADO extension and the GitHub action
katydecorah
added a commit
that referenced
this pull request
Dec 12, 2022
…1448) #### Details This pull request will remove the GitHub action from the build pipeline. ##### Motivation <!-- This can be as simple as "addresses issue #123" --> ##### Context <!-- Are there any parts that you've intentionally left out-of-scope for a later PR to handle? --> From what I understand, the gh-action was placed in an artifact at `drop/packages/gh-action/`, while the extension lives in an artifact at `ado-extension-drop/pkg/`. This PR will remove the `drop/` directory at the root since that appears to be for the action only. The REALEASE_COMMIT.md was saved in `ado-extension-drop/drop`, but I moved that up a directory into `ado-extension-drop` to simplify the directory structure. - Example of artifact before this PR: https://dev.azure.com/accessibility-insights-private/Accessibility%20Insights%20(private)/_build/results?buildId=40217&view=artifacts&pathAsName=false&type=publishedArtifacts - Example of artifact with this PR: https://dev.azure.com/accessibility-insights-private/Accessibility%20Insights%20(private)/_build/results?buildId=40411&view=artifacts&pathAsName=false&type=publishedArtifacts <!-- Were there any alternative approaches you considered? What tradeoffs did you consider? --> #### Pull request checklist <!-- If a checklist item is not applicable to this change, write "n/a" in the checkbox --> - [n/a] Addresses an existing issue: Fixes #0000 - [x] Added relevant unit test for your changes. (`yarn test`) - [x] Verified code coverage for the changes made. Check coverage report at: `<rootDir>/test-results/unit/coverage` - [x] Ran precheckin (`yarn precheckin`) - [x] Described how this PR impacts both the ADO extension and the GitHub action
JGibson2019
added a commit
that referenced
this pull request
Apr 28, 2023
#### Details Removed the `yaml` dependency and updated to a later version of the `cosmiconfig` package that uses `js-yaml` instead <!-- Usually a sentence or two describing what the PR changes --> ##### Motivation The older version of `yaml` had a security vulnerability. Since the dependency was introduced by `cosmiconfig`, opted to update this package, which switched to the `js-yaml` parser <!-- This can be as simple as "addresses issue #123" --> ##### Context <!-- Are there any parts that you've intentionally left out-of-scope for a later PR to handle? --> <!-- Were there any alternative approaches you considered? What tradeoffs did you consider? --> #### Pull request checklist <!-- If a checklist item is not applicable to this change, write "n/a" in the checkbox --> - [N/A] Addresses an existing issue: Fixes #0000 - [N/A] Added relevant unit test for your changes. (`yarn test`) - [x] Verified code coverage for the changes made. Check coverage report at: `<rootDir>/test-results/unit/coverage` - [x] Ran precheckin (`yarn precheckin`)
DaveTryon
added a commit
that referenced
this pull request
Sep 22, 2023
#### Details Due to jestjs/jest#14305, our inline snapshots are causing problems when using `yarn test -u`. We discussed this internally and decided that the simplest approach was to convert the inline snapshots to traditional snapshots. For most cases, this was just removing "Inline" from the method name and removing the string that provided the snapshot. A small number of test cases were checking multiple inline snapshots in the same test, so the approach there was to build an array of the things that were previously checked individually, then having a single snapshot for the test case. I ran `yarn test -u` and `yarn format:fix` after making all of the changes, just to make sure that we're ready for future changes. It will probably be easiest to review this one commit at a time--each of the 32 commits represents the conversion of a single test case. ##### Motivation <!-- This can be as simple as "addresses issue #123" --> ##### Context <!-- Are there any parts that you've intentionally left out-of-scope for a later PR to handle? --> <!-- Were there any alternative approaches you considered? What tradeoffs did you consider? --> #### Pull request checklist <!-- If a checklist item is not applicable to this change, write "n/a" in the checkbox --> - [n/a] Addresses an existing issue: - [x] Added relevant unit test for your changes. (`yarn test`) - [x] Verified code coverage for the changes made. Check coverage report at: `<rootDir>/test-results/unit/coverage` - [x] Ran precheckin (`yarn precheckin`)
v-viyada
added a commit
that referenced
this pull request
Mar 6, 2024
…tes (#2028) #### Details react-router-dom is used for test website for testing Urls with hash fragments. The feature hashType="noslash" used in test website is not supported from v6. Please refer remix-run/react-router#11076 for more details. As per this, this feature is not going to be supported in future version so we have to stick with v5 only Also closed out dependabot PR #2024 ##### Motivation <!-- This can be as simple as "addresses issue #123" --> ##### Context <!-- Are there any parts that you've intentionally left out-of-scope for a later PR to handle? --> <!-- Were there any alternative approaches you considered? What tradeoffs did you consider? --> #### Pull request checklist <!-- If a checklist item is not applicable to this change, write "n/a" in the checkbox --> - [n/a] Addresses an existing issue: Fixes #0000 - [n/a] Added relevant unit test for your changes. (`yarn test`) - [n/a] Verified code coverage for the changes made. Check coverage report at: `<rootDir>/test-results/unit/coverage` - [x] Ran precheckin (`yarn precheckin`)
v-viyada
added a commit
that referenced
this pull request
Mar 21, 2024
#2044) #### Details Update new service connection name for publishing ADO extension to market place. New service connection name is created in mseng ADO as we have to migrate our pipelines to this ADO. ##### Motivation <!-- This can be as simple as "addresses issue #123" --> ##### Context <!-- Are there any parts that you've intentionally left out-of-scope for a later PR to handle? --> <!-- Were there any alternative approaches you considered? What tradeoffs did you consider? --> #### Pull request checklist <!-- If a checklist item is not applicable to this change, write "n/a" in the checkbox --> - [n/a] Addresses an existing issue: Fixes #0000 - [n/a] Added relevant unit test for your changes. (`yarn test`) - [n/a] Verified code coverage for the changes made. Check coverage report at: `<rootDir>/test-results/unit/coverage` - [x] Ran precheckin (`yarn precheckin`)
v-viyada
added a commit
that referenced
this pull request
Mar 22, 2024
…lines (#2046) #### Details Created new variable groups, service connections and environments in mseng ADO. As this is common ADO for different team so appended a11y-insights in all the names to distinguish them for our team. ##### Motivation <!-- This can be as simple as "addresses issue #123" --> ##### Context <!-- Are there any parts that you've intentionally left out-of-scope for a later PR to handle? --> <!-- Were there any alternative approaches you considered? What tradeoffs did you consider? --> #### Pull request checklist <!-- If a checklist item is not applicable to this change, write "n/a" in the checkbox --> - [n/a] Addresses an existing issue: Fixes #0000 - [n/a] Added relevant unit test for your changes. (`yarn test`) - [n/a] Verified code coverage for the changes made. Check coverage report at: `<rootDir>/test-results/unit/coverage` - [n/a] Ran precheckin (`yarn precheckin`)
v-viyada
added a commit
that referenced
this pull request
Mar 22, 2024
…pipeline (#2047) #### Details Updated git hub service connection name for creating release tag from mseng ADO. ##### Motivation <!-- This can be as simple as "addresses issue #123" --> ##### Context <!-- Are there any parts that you've intentionally left out-of-scope for a later PR to handle? --> <!-- Were there any alternative approaches you considered? What tradeoffs did you consider? --> #### Pull request checklist <!-- If a checklist item is not applicable to this change, write "n/a" in the checkbox --> - [n/a] Addresses an existing issue: Fixes #0000 - [n/a] Added relevant unit test for your changes. (`yarn test`) - [n/a] Verified code coverage for the changes made. Check coverage report at: `<rootDir>/test-results/unit/coverage` - [n/a] Ran precheckin (`yarn precheckin`)
v-viyada
added a commit
that referenced
this pull request
May 30, 2024
#### Details Axe core version upgrade to 4.8.4 for Accessibility Insights for Action ##### Motivation Upgrade the axe core version to latest 4.8.4 in Accessibility Insights for Action. Also update accessibility insights scan and report packages with latest versions which has axe-core version 4.8.4 <!-- This can be as simple as "addresses issue #123" --> User story - [User Story 2157659](https://dev.azure.com/mseng/1ES/_workitems/edit/2157659) ##### Context <!-- Are there any parts that you've intentionally left out-of-scope for a later PR to handle? --> <!-- Were there any alternative approaches you considered? What tradeoffs did you consider? --> #### Pull request checklist <!-- If a checklist item is not applicable to this change, write "n/a" in the checkbox --> - [x] Addresses an existing issue: Fixes #0000 - [x] Added relevant unit test for your changes. (`yarn test`) - [x] Verified code coverage for the changes made. Check coverage report at: `<rootDir>/test-results/unit/coverage` - [x] Ran precheckin (`yarn precheckin`) --------- Co-authored-by: Vikash Yadav <[email protected]>
v-viyada
added a commit
that referenced
this pull request
Sep 3, 2024
… Url in a11y ado extension (#2162) #### Details <!-- Usually a sentence or two describing what the PR changes --> Added two new optional parameter `npmRegistryUrl` and `npmRegistryCredential` to enable option to use private npm registry Url in a11y ado extension. If npmRegistryUrl is not set it will use https://registry.yarnpkg.com by default ##### Motivation <!-- This can be as simple as "addresses issue #123" --> [Feature 2207295](https://dev.azure.com/mseng/1ES/_workitems/edit/2207295): Enable option to use private npm registry Url in a11y ado extension ##### Context <!-- Are there any parts that you've intentionally left out-of-scope for a later PR to handle? --> <!-- Were there any alternative approaches you considered? What tradeoffs did you consider? --> #### Pull request checklist <!-- If a checklist item is not applicable to this change, write "n/a" in the checkbox --> - [ ] Addresses an existing issue: Fixes #0000 - [x] Added relevant unit test for your changes. (`yarn test`) - [x] Verified code coverage for the changes made. Check coverage report at: `<rootDir>/test-results/unit/coverage` - [x] Ran precheckin (`yarn precheckin`) --------- Co-authored-by: Vikash Yadav <[email protected]>
v-viyada
pushed a commit
that referenced
this pull request
Sep 6, 2024
…private registry parameter (#2166) #### Details <!-- Usually a sentence or two describing what the PR changes --> Added the new task in validation pipeline to validate the new parameter "npmRegistryUrl" functionality in pipeline ##### Motivation <!-- This can be as simple as "addresses issue #123" --> [Feature 2207295](https://dev.azure.com/mseng/1ES/_workitems/edit/2207295): Enable option to use private npm registry Url in a11y ado extension ##### Context <!-- Are there any parts that you've intentionally left out-of-scope for a later PR to handle? --> <!-- Were there any alternative approaches you considered? What tradeoffs did you consider? --> #### Pull request checklist <!-- If a checklist item is not applicable to this change, write "n/a" in the checkbox --> - [na] Addresses an existing issue: Fixes #0000 - [na] Added relevant unit test for your changes. (`yarn test`) - [na] Verified code coverage for the changes made. Check coverage report at: `<rootDir>/test-results/unit/coverage` - [x] Ran precheckin (`yarn precheckin`)
v-viyada
pushed a commit
that referenced
this pull request
Sep 12, 2024
#### Details Upgrade express from 4.19.2 to 4.20.0 to fix the vulnerability. Upgrade serve-static from 1.15.0 to 1.16.0 to fix the vulnerability. Upgrade send from 0.18.0 to 0.19.0 to fix the vulnerability. Upgrade body-parser from 1.20.2 to 1.20.3 to fix the vulnerability. Upgrade path-to-regexp from 0.1.7 to 0.1.10 to fix the vulnerability. Upgrade path-to-regexp from 1.8.0 to 1.9.0 to fix the vulnerability. <!-- Usually a sentence or two describing what the PR changes --> ##### Motivation <!-- This can be as simple as "addresses issue #123" --> [CG Work Items](https://dev.azure.com/mseng/1ES/_queries/query/894c54da-1edd-4c5c-ae4d-38903314430c/) ##### Context <!-- Are there any parts that you've intentionally left out-of-scope for a later PR to handle? --> <!-- Were there any alternative approaches you considered? What tradeoffs did you consider? --> #### Pull request checklist <!-- If a checklist item is not applicable to this change, write "n/a" in the checkbox --> - [ ] Addresses an existing issue: Fixes #0000 - [ ] Added relevant unit test for your changes. (`yarn test`) - [ ] Verified code coverage for the changes made. Check coverage report at: `<rootDir>/test-results/unit/coverage` - [ ] Ran precheckin (`yarn precheckin`)
JeevaniChinthala
added a commit
that referenced
this pull request
Sep 26, 2024
…2172) #### Details Updated resolutions for package [express](GHSA-qw6h-vgh9-j6wx), [serve-static](GHSA-cm22-4g7w-348p) and [send](GHSA-m6fv-jmcg-4jfg). <!-- Usually a sentence or two describing what the PR changes --> ##### Motivation <!-- This can be as simple as "addresses issue #123" --> [CG Work Items](https://dev.azure.com/mseng/1ES/_queries/query/894c54da-1edd-4c5c-ae4d-38903314430c/) ##### Context <!-- Are there any parts that you've intentionally left out-of-scope for a later PR to handle? --> <!-- Were there any alternative approaches you considered? What tradeoffs did you consider? --> #### Pull request checklist <!-- If a checklist item is not applicable to this change, write "n/a" in the checkbox --> - [x] Addresses an existing issue: Fixes #0000 - [ ] Added relevant unit test for your changes. (`yarn test`) - [ ] Verified code coverage for the changes made. Check coverage report at: `<rootDir>/test-results/unit/coverage` - [ ] Ran precheckin (`yarn precheckin`) --------- Co-authored-by: Jeevani Chinthala <[email protected]>
v-viyada
added a commit
that referenced
this pull request
Oct 1, 2024
…onment variables (#2186) #### Details This PR adjust the logic to set yarn config before installing runtime dependencies. It filters out environment variables starting with yarn_. This is to make Yarn commands for ado extension independent of any environment setting and if environment variable contains invalid/unrecognized variable starting with yarn_ than it throughs error. For example, environment YARN_MIN_VERSION (This is no valid config in yarn 3) will give below error: _Unrecognized or legacy configuration settings found: minVersion - run "yarn config -v" to see the list of settings supported in Yarn (in <environment>)_ Also it updates accessibility insights scan package to fix the issue #2182. ##### Motivation <!-- This can be as simple as "addresses issue #123" --> ##### Context <!-- Are there any parts that you've intentionally left out-of-scope for a later PR to handle? --> <!-- Were there any alternative approaches you considered? What tradeoffs did you consider? --> #### Pull request checklist <!-- If a checklist item is not applicable to this change, write "n/a" in the checkbox --> - [x] Addresses an existing issue: Fixes #2182 - [x] Added relevant unit test for your changes. (`yarn test`) - [ ] Verified code coverage for the changes made. Check coverage report at: `<rootDir>/test-results/unit/coverage` - [x] Ran precheckin (`yarn precheckin`)
v-viyada
added a commit
that referenced
this pull request
Nov 14, 2024
…o 1ES PT (#2225) #### Details <!-- Usually a sentence or two describing what the PR changes --> Migrated release pipeline to 1ES PT as per the changes mentioned in the documentation link provided for the 1ES pipeline migration. Test Run link: https://dev.azure.com/mseng/1ES/_build/results?buildId=29327650&view=results ##### Motivation <!-- This can be as simple as "addresses issue #123" --> [Feature 2211959](https://dev.azure.com/mseng/1ES/_workitems/edit/2211959) ##### Context <!-- Are there any parts that you've intentionally left out-of-scope for a later PR to handle? --> <!-- Were there any alternative approaches you considered? What tradeoffs did you consider? --> #### Pull request checklist <!-- If a checklist item is not applicable to this change, write "n/a" in the checkbox --> - [x] Addresses an existing issue: [Feature 2211959](https://dev.azure.com/mseng/1ES/_workitems/edit/2211959) - [ ] Added relevant unit test for your changes. (`yarn test`) - [ ] Verified code coverage for the changes made. Check coverage report at: `<rootDir>/test-results/unit/coverage` - [x] Ran precheckin (`yarn precheckin`) --------- Co-authored-by: Vikash Yadav <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps @types/jest from 25.2.1 to 25.2.2.
Commits
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot badge me
will comment on this PR with code to add a "Dependabot enabled" badge to your readmeAdditionally, you can set the following in the
.dependabot/config.yml
file in this repo: