Simplify handling of `node:`-prefixed modules in auto-imports #59702

andrewbranch · 2024-08-20T22:52:39Z

Our previous behavior is described in #45080. The new behavior implemented here is simpler:

Preference inference: any node:-prefixed import that is not one of the built-ins only available with the prefix (e.g. node:test) indicates a preference for using the prefix. If no built-ins are referenced besides the ones only available with the prefix, no preference is set. Otherwise, the preference is to avoid the prefix. When a preference can be inferred from the imports in a single file, that will be used for auto-imports in that file. Otherwise, the same algorithm is used for all imports in non-node_modules, non-declaration files.
Both codefixes and completions only offer auto-imports matching the inferred preference. If no preference could be inferred, both variants are offered. (Generally, this means new projects will see both options the first time they auto-import a built-in module, and then never again.)

…nything from exclusively prefixed modules

andrewbranch · 2024-08-20T22:52:50Z

typescript-bot · 2024-08-20T22:52:54Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`perf test`	✅ Started	👀 Results

typescript-bot · 2024-08-20T23:37:30Z

@andrewbranch
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,153	_62,153	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,242	_50,242	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{193,011k (± 0.74%)}	_{193,596k (± 0.91%)}	_~	_192,352k	_195,900k	_{p=0.689 n=6}
_{Parse Time}	_{1.57s (± 0.94%)}	_{1.58s (± 0.78%)}	_~	_1.56s	_1.59s	_{p=0.408 n=6}
_{Bind Time}	_{0.86s (± 0.60%)}	_{0.86s (± 1.27%)}	_~	_0.84s	_0.87s	_{p=0.324 n=6}
_{Check Time}	_{11.39s (± 0.12%)}	_{11.41s (± 0.23%)}	_~	_11.38s	_11.45s	_{p=0.221 n=6}
_{Emit Time}	_{3.24s (± 0.54%)}	_{3.23s (± 0.77%)}	_~	_3.21s	_3.27s	_{p=0.685 n=6}
_{Total Time}	_{17.05s (± 0.13%)}	_{17.08s (± 0.15%)}	_~	_17.05s	_17.12s	_{p=0.076 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₇	₇	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_945,753	_945,753	_~	_~	_~	_{p=1.000 n=6}
_Types	_410,067	_410,067	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,222,683k (± 0.00%)}	_{1,222,703k (± 0.00%)}	_~	_1,222,677k	_1,222,754k	_{p=0.296 n=6}
_{Parse Time}	_{7.91s (± 0.65%)}	_{7.89s (± 0.34%)}	_~	_7.84s	_7.92s	_{p=0.294 n=6}
_{Bind Time}	_{2.21s (± 0.67%)}	_{2.21s (± 0.44%)}	_~	_2.20s	_2.23s	_{p=1.000 n=6}
_{Check Time}	_{36.31s (± 0.15%)}	_{36.38s (± 0.40%)}	_~	_36.21s	_36.53s	_{p=0.689 n=6}
_{Emit Time}	_{17.75s (± 0.89%)}	_{17.76s (± 0.48%)}	_~	_17.64s	_17.88s	_{p=1.000 n=6}
_{Total Time}	_{64.17s (± 0.24%)}	_{64.23s (± 0.27%)}	_~	_64.06s	_64.52s	_{p=0.630 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,508,161	_2,508,161	_~	_~	_~	_{p=1.000 n=6}
_Types	_992,225	_992,225	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,375,653k (± 0.00%)}	_{2,375,721k (± 0.00%)}	_~	_2,375,603k	_2,375,815k	_{p=0.229 n=6}
_{Parse Time}	_{13.57s (± 0.16%)}	_{13.62s (± 0.31%)}	_~	_13.57s	_13.68s	_{p=0.052 n=6}
_{Bind Time}	_{3.24s (± 0.61%)}	_{3.24s (± 0.80%)}	_~	_3.21s	_3.28s	_{p=0.742 n=6}
_{Check Time}	_{107.24s (± 0.44%)}	_{107.11s (± 0.32%)}	_~	_106.50s	_107.49s	_{p=0.471 n=6}
_{Emit Time}	_{0.39s (± 3.39%)}	_{0.40s (± 2.74%)}	_~	_0.38s	_0.41s	_{p=0.306 n=6}
_{Total Time}	_{124.44s (± 0.38%)}	_{124.36s (± 0.27%)}	_~	_123.72s	_124.72s	_{p=0.575 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,231,998	_1,231,997	_{-1 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_264,591	_264,572	_{-19 (- 0.01%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,353,766k (± 0.02%)}	_{2,353,934k (± 0.02%)}	_~	_2,353,272k	_2,354,327k	_{p=0.575 n=6}
_{Parse Time}	_{6.06s (± 1.10%)}	_{6.01s (± 1.10%)}	_~	_5.95s	_6.11s	_{p=0.298 n=6}
_{Bind Time}	_{2.27s (± 0.76%)}	_{2.25s (± 1.27%)}	_~	_2.21s	_2.30s	_{p=0.145 n=6}
_{Check Time}	_{40.97s (± 0.32%)}	_{41.12s (± 0.20%)}	_~	_41.02s	_41.25s	_{p=0.093 n=6}
_{Emit Time}	_{4.14s (± 4.07%)}	_{4.02s (± 1.55%)}	_~	_3.91s	_4.08s	_{p=0.575 n=6}
_{Total Time}	_{53.46s (± 0.48%)}	_{53.42s (± 0.22%)}	_~	_53.26s	_53.58s	_{p=0.810 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,231,998	_1,231,997	_{-1 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_264,591	_264,572	_{-19 (- 0.01%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,428,353k (± 0.04%)}	_{2,428,895k (± 0.02%)}	_~	_2,427,853k	_2,429,566k	_{p=0.689 n=6}
_{Parse Time}	_{7.77s (± 0.72%)}	_{7.72s (± 0.76%)}	_~	_7.64s	_7.81s	_{p=0.230 n=6}
_{Bind Time}	_{2.66s (± 6.53%)}	_{2.51s (± 1.50%)}	_~	_2.47s	_2.58s	_{p=0.146 n=6}
_{Check Time}	_{51.49s (± 0.78%)}	_{51.23s (± 0.74%)}	_~	_50.90s	_51.78s	_{p=0.378 n=6}
_{Emit Time}	_{5.03s (± 0.91%)}	_{5.08s (± 2.92%)}	_~	_4.97s	_5.38s	_{p=0.630 n=6}
_{Total Time}	_{66.96s (± 0.43%)}	_{66.57s (± 0.53%)}	_~	_66.21s	_67.13s	_{p=0.066 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_256,992	_257,004	_{+12 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_105,667	_105,761	_{+94 (+ 0.09%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{429,661k (± 0.02%)}	_{429,705k (± 0.02%)}	_~	_429,605k	_429,887k	_{p=0.575 n=6}
_{Parse Time}	_{3.36s (± 0.53%)}	_{3.35s (± 0.85%)}	_~	_3.31s	_3.39s	_{p=0.466 n=6}
_{Bind Time}	_{1.29s (± 0.94%)}	_{1.29s (± 0.91%)}	_~	_1.28s	_1.31s	_{p=0.718 n=6}
_{Check Time}	_{18.07s (± 0.12%)}	_{18.16s (± 0.39%)}	_~	_18.07s	_18.24s	_{p=0.054 n=6}
_{Emit Time}	_{1.65s (± 1.55%)}	_{1.66s (± 1.76%)}	_~	_1.63s	_1.71s	_{p=0.806 n=6}
_{Total Time}	_{24.37s (± 0.21%)}	_{24.46s (± 0.41%)}	_~	_24.30s	_24.58s	_{p=0.090 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₆₈	₆₈	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_225,018	_225,018	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,249	_94,249	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{370,179k (± 0.01%)}	_{370,216k (± 0.02%)}	_~	_370,124k	_370,334k	_{p=0.471 n=6}
_{Parse Time}	_{2.77s (± 0.72%)}	_{2.75s (± 0.58%)}	_~	_2.72s	_2.76s	_{p=0.121 n=6}
_{Bind Time}	_{1.57s (± 0.53%)}	_{1.57s (± 0.63%)}	_~	_1.56s	_1.58s	_{p=0.588 n=6}
_{Check Time}	_{15.74s (± 0.36%)}	_{15.74s (± 0.28%)}	_~	_15.67s	_15.80s	_{p=1.000 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{20.08s (± 0.28%)}	_{20.05s (± 0.27%)}	_~	_19.99s	_20.14s	_{p=0.470 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₆₆	₆₆	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_3,017,597	_3,017,597	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,038,326	_1,038,326	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,137,064k (± 0.00%)}	_{3,137,087k (± 0.00%)}	_~	_3,137,029k	_3,137,130k	_{p=0.422 n=6}
_{Parse Time}	_{17.23s (± 0.46%)}	_{17.28s (± 0.36%)}	_~	_17.21s	_17.37s	_{p=0.421 n=6}
_{Bind Time}	_{5.22s (± 0.16%)}	_{5.26s (± 1.93%)}	_~	_5.20s	_5.47s	_{p=0.565 n=6}
_{Check Time}	_{97.31s (± 0.57%)}	_{97.45s (± 0.44%)}	_~	_96.91s	_97.95s	_{p=1.000 n=6}
_{Emit Time}	_{25.00s (± 0.77%)}	_{24.95s (± 0.42%)}	_~	_24.82s	_25.07s	_{p=1.000 n=6}
_{Total Time}	_{144.77s (± 0.41%)}	_{144.95s (± 0.25%)}	_~	_144.54s	_145.42s	_{p=0.575 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_275,310	_275,310	_~	_~	_~	_{p=1.000 n=6}
_Types	_112,431	_112,431	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{424,211k (± 0.02%)}	_{424,175k (± 0.02%)}	_~	_424,082k	_424,337k	_{p=0.378 n=6}
_{Parse Time}	_{3.98s (± 0.47%)}	_{3.98s (± 0.52%)}	_~	_3.94s	_3.99s	_{p=0.935 n=6}
_{Bind Time}	_{1.72s (± 1.44%)}	_{1.74s (± 0.79%)}	_~	_1.72s	_1.75s	_{p=0.460 n=6}
_{Check Time}	_{17.54s (± 0.27%)}	_{17.58s (± 0.30%)}	_~	_17.52s	_17.67s	_{p=0.226 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{23.24s (± 0.24%)}	_{23.29s (± 0.28%)}	_~	_23.18s	_23.38s	_{p=0.092 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_534,554	_534,554	_~	_~	_~	_{p=1.000 n=6}
_Types	_176,379	_176,379	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{479,387k (± 0.01%)}	_{479,399k (± 0.01%)}	_~	_479,340k	_479,468k	_{p=0.810 n=6}
_{Parse Time}	_{2.84s (± 0.74%)}	_{2.83s (± 0.52%)}	_~	_2.81s	_2.85s	_{p=0.368 n=6}
_{Bind Time}	_{1.04s (± 0.80%)}	_{1.05s (± 0.78%)}	_~	_1.03s	_1.05s	_{p=0.673 n=6}
_{Check Time}	_{15.32s (± 0.26%)}	_{15.30s (± 0.20%)}	_~	_15.25s	_15.34s	_{p=0.192 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{19.21s (± 0.24%)}	_{19.18s (± 0.16%)}	_~	_19.12s	_19.21s	_{p=0.126 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

tsserver

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,300ms (± 0.14%)}	_{2,298ms (± 0.16%)}	_~	_2,292ms	_2,302ms	_{p=0.629 n=6}
_{Req 2 - geterr}	_{5,175ms (± 0.64%)}	_{5,162ms (± 0.33%)}	_~	_5,139ms	_5,183ms	_{p=0.810 n=6}
_{Req 3 - references}	_{263ms (± 0.91%)}	_{262ms (± 0.20%)}	_~	_262ms	_263ms	_{p=0.923 n=6}
_{Req 4 - navto}	_{227ms (± 0.54%)}	_{227ms (± 0.71%)}	_~	_224ms	_229ms	_{p=0.673 n=6}
_{Req 5 - completionInfo count}	_1,357	_1,357	_~	_~	_~	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{85ms (± 5.04%)}	_{82ms (± 6.46%)}	_~	_76ms	_87ms	_{p=0.457 n=6}
_{CompilerTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,410ms (± 1.08%)}	_{2,407ms (± 1.70%)}	_~	_2,348ms	_2,460ms	_{p=1.000 n=6}
_{Req 2 - geterr}	_{3,924ms (± 0.23%)}	_{3,911ms (± 0.25%)}	_{-14ms (- 0.35%)}	_3,895ms	_3,922ms	_{p=0.045 n=6}
_{Req 3 - references}	_{275ms (± 1.91%)}	_{273ms (± 0.59%)}	_~	_270ms	_274ms	_{p=0.869 n=6}
_{Req 4 - navto}	_{229ms (± 2.30%)}	_{230ms (± 2.25%)}	_~	_227ms	_240ms	_{p=0.865 n=6}
_{Req 5 - completionInfo count}	_1,519	_1,519	_~	_~	_~	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{78ms (± 9.08%)}	_{77ms (± 8.67%)}	_~	_69ms	_86ms	_{p=1.000 n=6}
_{xstate-main-1-tsserver - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{5,192ms (± 0.31%)}	_{5,192ms (± 0.18%)}	_~	_5,176ms	_5,204ms	_{p=0.630 n=6}
_{Req 2 - geterr}	_{1,134ms (± 1.86%)}	_{1,130ms (± 1.05%)}	_~	_1,111ms	_1,141ms	_{p=0.575 n=6}
_{Req 3 - references}	_{87ms (± 4.06%)}	_{89ms (± 4.02%)}	_~	_84ms	_92ms	_{p=0.511 n=6}
_{Req 4 - navto}	_{444ms (± 0.88%)}	_{441ms (± 0.20%)}	_~	_440ms	_442ms	_{p=0.084 n=6}
_{Req 5 - completionInfo count}	_3,444	_3,444	_~	_~	_~	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{836ms (± 1.45%)}	_{820ms (± 1.54%)}	_{-17ms (- 1.97%)}	_806ms	_837ms	_{p=0.045 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

CompilerTSServer - node (v18.15.0, x64)
Compiler-UnionsTSServer - node (v18.15.0, x64)
xstate-main-1-tsserver - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

startup

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v18.15.0, x64)}
_{Execution time}	_{157.90ms (± 0.17%)}	_{158.10ms (± 0.17%)}	_{+0.20ms (+ 0.13%)}	_157.06ms	_160.28ms	_{p=0.000 n=600}
_{tsserver-startup - node (v18.15.0, x64)}
_{Execution time}	_{231.95ms (± 0.13%)}	_{231.97ms (± 0.14%)}	_~	_230.61ms	_238.21ms	_{p=0.835 n=600}
_{tsserverlibrary-startup - node (v18.15.0, x64)}
_{Execution time}	_{227.70ms (± 0.15%)}	_{227.50ms (± 0.14%)}	_{-0.20ms (- 0.09%)}	_226.00ms	_231.27ms	_{p=0.000 n=600}
_{typescript-startup - node (v18.15.0, x64)}
_{Execution time}	_{227.77ms (± 0.14%)}	_{227.82ms (± 0.23%)}	_~	_226.38ms	_244.53ms	_{p=0.516 n=600}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

tsc-startup - node (v18.15.0, x64)
tsserver-startup - node (v18.15.0, x64)
tsserverlibrary-startup - node (v18.15.0, x64)
typescript-startup - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

sheetalkamat

Change looks good to me but pls fix the knip issue

andrewbranch added 3 commits August 19, 2024 17:03

Simplify handling of node:-prefixed modules

df0a612

Consistify in-file inference with other-file inference; don’t infer a…

cf485b4

…nything from exclusively prefixed modules

Fix lint

1e2711f

typescript-bot assigned andrewbranch Aug 20, 2024

typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Aug 20, 2024

Add comments for scraping node core modules

35805ef

andrewbranch requested review from sheetalkamat and sandersn August 21, 2024 16:15

sheetalkamat approved these changes Aug 21, 2024

View reviewed changes

Fix knip

ec6461c

andrewbranch changed the title ~~Simplify handling of node:-prefixed modules~~ Simplify handling of node:-prefixed modules in auto-imports Aug 21, 2024

andrewbranch merged commit a5eec24 into microsoft:main Aug 21, 2024
32 checks passed

andrewbranch deleted the auto-imports-consistent-node-prefix branch August 21, 2024 23:43

DanielRosenwasser added this to the TypeScript 5.7.0 milestone Aug 23, 2024

DanielRosenwasser mentioned this pull request Sep 9, 2024

TypeScript 5.7 Iteration Plan #59905

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Simplify handling of `node:`-prefixed modules in auto-imports #59702

Simplify handling of `node:`-prefixed modules in auto-imports #59702

andrewbranch commented Aug 20, 2024

andrewbranch commented Aug 20, 2024

typescript-bot commented Aug 20, 2024 •

edited

Loading

typescript-bot commented Aug 20, 2024

tsc

tsserver

startup

sheetalkamat left a comment

Simplify handling of node:-prefixed modules in auto-imports #59702

Simplify handling of node:-prefixed modules in auto-imports #59702

Conversation

andrewbranch commented Aug 20, 2024

andrewbranch commented Aug 20, 2024

typescript-bot commented Aug 20, 2024 • edited Loading

typescript-bot commented Aug 20, 2024

tsc

tsserver

startup

sheetalkamat left a comment

Choose a reason for hiding this comment

Simplify handling of `node:`-prefixed modules in auto-imports #59702

Simplify handling of `node:`-prefixed modules in auto-imports #59702

typescript-bot commented Aug 20, 2024 •

edited

Loading