allowJs:true + declaration:true

[nojvek]

• There is an associated issue. Fixes Allow --declaration with --allowJs #7546
• Code is up-to-date with the master branch
• You've successfully run jake runtests locally
• You've signed the CLA
• There are new or updated unit tests validating the change

** TODO **

From previous PR: #15911

• Fix commented out tsserver test. Not sure what the correct fix is
• ES5 prototype style function definitions

function f() {
}
f.prototype.method = function() {}   // should probably emit a class?

• @typedef {Object} SpecialType -> Interfaces

/**
 * @typedef {object} SpecialType1 - creates a new type named 'SpecialType'
 * @property {string} prop1 - a string property of SpecialType
 * @property {number} prop2 - a number property of SpecialType
 * @property {number=} prop3 - an optional number property of SpecialType
 */
/** @type {SpecialType1} */
var specialTypeObject1;

• Recognize @private/@readonly -> private X / readonly X

  /** @private */
  _render() {...}

  /** @readonly */
  static observedAttributes() {...}

[sheetalkamat]

you could change this to set { "inlineSourceMap": true, "sourceMap": true } to make sure the errors are reported on those lines in the config file.

[GirlBossRush]

This looks awesome! Is there an ETA to release?

[nojvek]

Needs some work on emitting part for type interfaces described in jsdocs. I’ve been using puppeteer project as a real world test case to solve. Typescript doesn’t understand that module.exports should also export the interfaces so need to solve that too. I think a lot of these can be sped up if I could get a mentor from Typescript team. This isn’t as easy as I thought it would be. Please help Typescript.

[DSchroer]

I did a quick test of this on a project I am developing for. It works great except that it automatically detects require("SOMETHING") as a module import even if the TypeScript module setting is set to none.

This is a weird quirk of the code I am dealing with but it would be nice to be able to disable module detection. Since in my case require is just another function.

[nojvek]

Yeah there are lots of little quirks like that to work out.

But being able to auto-generate types for js projects is going to be amazing.

[weswigham]

@nojvek Once #21930 is merged, I'd like to write a transformer for JS files that simply iterates over their exported symbols, gets their declared types, and uses a modified typeToTypeNode on them to generate declarations for all required symbols. It needs to be a very different process from our usual subtractive declaration emit.

[nojvek]

ooo I like it. Do you have a guesstimate for the merge ?

[nojvek]

Typescript 2.9 has introduced some nice goodies. I am going to take another stab at this.

Really liking what the improvements to jsdoc and codecompletion. Whoever did that. Thank you!

[ahocevar]

What needs to be done to finish this effort?

[nojvek]

I basically just need to re-focus and get back into it. TSC has moved some pieces around so need to re-base and figure out the merge conflicts + tests.

Hopefully we don't end up bikeshedding again. Been trying to land this since last year now 😞

[weswigham]

You probably want to start fresh rather than attempt a rebase - the declaration emit pipeline has entirely changed since this PR was last updated.

[RyanCavanaugh]

@nojvek thanks for the work so far! I'm going to close this since it's going to require a substantial rebasing anyway. Looking forward to the next iteration.