Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibly missing properties in the ts.server.protocol.CompilerOptions interface #57232

Closed
6 tasks done
mrazauskas opened this issue Jan 30, 2024 · 0 comments Β· Fixed by #57361
Closed
6 tasks done

Possibly missing properties in the ts.server.protocol.CompilerOptions interface #57232

mrazauskas opened this issue Jan 30, 2024 · 0 comments Β· Fixed by #57361
Assignees
Labels
Needs Investigation This issue needs a team member to investigate its status.

Comments

@mrazauskas
Copy link

mrazauskas commented Jan 30, 2024

πŸ” Search Terms

"server", "protocol", "CompilerOptions"

βœ… Viability Checklist

⭐ Suggestion

Just wanted to draw your attention that the ts.server.protocol.CompilerOptions interface is missing recently added properties that are present in ts.CompilerOptions. Like allowImportingTsExtensions, resolvePackageJsonExports, resolvePackageJsonImports, allowArbitraryExtensions , etc. Probably there are more:

export interface CompilerOptions {
allowJs?: boolean;
allowSyntheticDefaultImports?: boolean;
allowUnreachableCode?: boolean;
allowUnusedLabels?: boolean;
alwaysStrict?: boolean;

preserveSymlinks?: boolean;
project?: string;
reactNamespace?: string;
removeComments?: boolean;
references?: ProjectReference[];
rootDir?: string;
rootDirs?: string[];
skipLibCheck?: boolean;

πŸ“ƒ Motivating Example

Similar to: #56785 (comment)

@andrewbranch Could you take a look, please? Perhaps it is worth adding these too?

πŸ’» Use Cases

Index signature covers them all. So this is not a problem. Only felt like those should be explicitly defined.

By the way, deprecated options like suppressExcessPropertyErrors, suppressImplicitAnyIndexErrors most probably have to be removed from ts.server.protocol.CompilerOptions in TypeScript 5.5.

strict?: boolean;
strictNullChecks?: boolean;
suppressExcessPropertyErrors?: boolean;
suppressImplicitAnyIndexErrors?: boolean;
useDefineForClassFields?: boolean;
target?: ScriptTarget | ts.ScriptTarget;

@RyanCavanaugh RyanCavanaugh added the Needs Investigation This issue needs a team member to investigate its status. label Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Investigation This issue needs a team member to investigate its status.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants