Inlay hints for type parameters on type arguments

[jonlepage]

hi, can we support ts generic for editor.inlayHints ?
I love this feature with a shortcut , but it seem missing ts support .
thanks

---

actually

---

expected result (photoshoped)

[andrewbranch]

@MariaSolOs might have opinions.

[MariaSolOs]

@andrewbranch @djmisterjon This has already been implemented in #55141, it's just waiting for a review.

[andrewbranch]

I might be missing it, but I don’t see any type arguments in any of those tests 🤔

[MariaSolOs]

I might be missing it, but I don’t see any type arguments in any of those tests 🤔

I think you're right. But after reading this issue better I'm a bit unsure of what the ask is? Where exactly would the hint be?

[jonlepage]

I might be missing it, but I don’t see any type arguments in any of those tests 🤔

I think you're right. But after reading this issue better I'm a bit unsure of what the ask is? Where exactly would the hint be?

sorry , in this context the params are upper and args at bottom
A would like to know if your arch allow possibility to expose args names in params for ts generics.

i probably use a different theme design who add confusion sry, in js you can expose args in params like this :)

it this help to understand the request ?

[MariaSolOs]

@djmisterjon It does! Thank you for the example :)
This does sound like a new feature request indeed. The PR I linked previously is adding support for interacting with existing inlay hints, but you're suggesting a new case in where to display them.

[jonlepage]

@djmisterjon It does! Thank you for the example :) This does sound like a new feature request indeed. The PR I linked previously is adding support for interacting with existing inlay hints, but you're suggesting a new case in where to display them.

I'm not very familiar with the ts project architecture, but yes, I believe it was indeed a new feature and not a modification of an existing one.
Or is it out of scope of ts ?

maybe i would be better to transfer the request to the side of vscode team ?
i was not sure if it a vscode feature or ts support or both !?

[MariaSolOs]

@djmisterjon no worries! Yes this issue is in the right place :)

[jonlepage]

Hmm, i ask myself if the reason why this feature was not implemented at the same time as JavaScript's Hints is probably because it's more complicated to achieve due to the freedom of syntax and formatting complexity that TypeScript allows, unlike JavaScript.

I remember encountering a similar issue with some other libraries in a similar context.
for example: where ESLint stopped supporting the INDENT RULE for TypeScript generics because TypeScript offers too much syntax freedom and formatting flexibility.
typescript-eslint/typescript-eslint#1824