Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"TypeScript for Visual Studio" installer not available for 5.1 #54685

Closed
wnayes opened this issue Jun 17, 2023 · 8 comments
Closed

"TypeScript for Visual Studio" installer not available for 5.1 #54685

wnayes opened this issue Jun 17, 2023 · 8 comments
Assignees
Labels
Needs Investigation This issue needs a team member to investigate its status.

Comments

@wnayes
Copy link
Contributor

wnayes commented Jun 17, 2023

Bug Report

There does not appear to be a "TypeScript 5.1 for Visual Studio" installer available on marketplace.visualstudio.com.

Previous releases of TypeScript have had installers made available, such as this one for 5.0.4.

Was it intended to stop publishing this for 5.1 onward?

🔎 Search Terms

Visual Studio 2019/2022, Windows SDK

@fatcerberus
Copy link

#54686 seems like it might be related

@RyanCavanaugh RyanCavanaugh added the Needs Investigation This issue needs a team member to investigate its status. label Jun 19, 2023
@HannahOshlag
Copy link
Contributor

5.1.3 has now been published. Here is the link to it: https://marketplace.visualstudio.com/items?itemName=TypeScriptTeam.typescript-513

Apologies that it did not go up immediately. Future publishes should happen simultaneously with the NuGet releases.

@HolgerJeromin
Copy link
Contributor

Does this even work with the buildin node 12 version in VS2019 (or even node 10 in VS2017)?

@cheit-epic
Copy link

@noshlag Simultaneous publishes don't seem to be working, since 5.2 is also missing from the marketplace.

@DanielRosenwasser
Copy link
Member

Does this even work with the buildin node 12 version in VS2019 (or even node 10 in VS2017)?

Unfortunately no - there are ways of customizing VS2019 to use an alternative version of Node.js, but TypeScript won't work with the built-in Node.js from VS2019.

publishes don't seem to be working, since 5.2 is also missing from the marketplace.

Apologies, there was an oversight in the publishing process. That said, I would highly recommend switching over to using NuGet, or more preferably npm, to customize the version of TypeScript used in VS.

@HolgerJeromin
Copy link
Contributor

HolgerJeromin commented Aug 29, 2023

Unfortunately no - there are ways of customizing VS2019 to use an alternative version of Node.js, but TypeScript won't work with the built-in Node.js from VS2019.

In my tests this published workaround did not worked at all. This is because
\packages\Microsoft.TypeScript.MSBuild.5.1.3\tools\Microsoft.TypeScript.targets
does not check this registry key at all.
ref #54686 (comment)

IMO this Microsoft.TypeScript.targets from the NuGet package should be adjusted in future releases but I did not find its source. It is easy to check $(registry:HKEY_LOCAL_MACHINE\SOFTWARE\Node.js@InstallPath) in it.

Working workaround is written in a later comment:
#54686 (comment)

@cheit-epic
Copy link

Same with 5.5. The beta is there but not the release.
We're working on moving away from relying on the SDK but it's a process.

@HolgerJeromin
Copy link
Contributor

@cheit-epic It was on nuget.org but not anymore (because it was buggy):
#57475 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Investigation This issue needs a team member to investigate its status.
Projects
None yet
Development

No branches or pull requests

8 participants