Design Meeting Notes, 2023-03-22

[RyanCavanaugh]

• TS 5 Regression. tsconfig extends stop resolving references to node_modules #53314 extends and module resolution
  • Longstanding: It's allowed to use a nonrelative path to make extends do module resolution
  • These paths, under module: nodenext (?), don't follow exports
  • How isn't this circular? The module resolution mode depends on what these exports resolve to, right?
    • No. We use static settings which use nodenext resolution (thus respect exports, or should)
  • Anyway. exports in package.json "blocks" direct file lookups, which means we can't "see" tsconfig.json files in the module
  • We could do nonstandard fallback to file resolution if exports fails?
  • If you're pulling your config from your package, you can add the export map
  • But if you're not, and it wasn't exported, then maybe you shouldn't be able to bring it in in the first place
    • Monorepo blurs this distinction between "yours" and "someone else's"
  • Are these module paths or file paths? Seems like a hybrid really in intuition, but maybe that intuition is simply wrong
  • If we just called require on these paths, this wouldn't work either. This is just us respecting the CJS specification re export maps
    • Broad agreement on this point
  • So we just have a bug that * isn't supported because we're not passing the flag
• Getter/setter assignability violations - make them ok?
  • No one present objects, but check in again later after TC39
• Upgrade "boolean-trivia" lint to new "argument-trivia" lint that uses type info, has quick fixes, etc. #53002 - better trivia lint rules
  • Somewhat slower
  • But does the right thing (actually detects the right name) and has a quick fix
  • This is what we had before way back in the day, but that rule was massively slower
  • OK
  • Should this enforce spaces?
    • Yes, no whitespaces please
• Convert debug namespace into a module, direct import #51455 Debug namespace as module w/ direct imports
  • Downside: Auto-import doesn't quite work right
  • Can we do something to fix it?
    • Open feature request for this
  • Not really a big deal given how often we make new files
  • OK, please review!