Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4.9.0-beta release is missing lib folder #50927

Closed
OliverJAsh opened this issue Sep 23, 2022 · 7 comments · Fixed by #50930
Closed

4.9.0-beta release is missing lib folder #50927

OliverJAsh opened this issue Sep 23, 2022 · 7 comments · Fixed by #50930
Assignees
@DanielRosenwasser
Labels
Bug A bug in TypeScript Infrastructure Issue relates to TypeScript team infrastructure
Milestone
TypeScript 4.9.1

Comments

@OliverJAsh
Copy link
Contributor

Bug Report

https://unpkg.com/browse/[email protected]/

It looks like the lib folder is missing?

After installing I see this error in VS Code:

image
@RyanCavanaugh
Copy link
Member

Investigating!

@DanielRosenwasser DanielRosenwasser self-assigned this Sep 23, 2022
@RyanCavanaugh
Copy link
Member

Today we learned that npm 8 supports ./ as a leading path component when specifying a directory in the package.json's files array, but not npm 6.

@DanielRosenwasser DanielRosenwasser mentioned this issue Sep 23, 2022
Merged
@DanielRosenwasser
Copy link
Member

549b542 fixes it, #50930 fixes it for future releases.

@fatcerberus
Copy link

Why is Ryan's comment being 👎🏼'd given that the the fix in #50930 aligns with it? Is there something I'm missing...?

@DanielRosenwasser
Copy link
Member

DanielRosenwasser commented Sep 23, 2022 •
edited
Loading

We have nothing against what Ryan said, we are just mad about the root cause. 😅

@RyanCavanaugh
Copy link
Member

The 👎 is coming from inside the house (my own account)

@DanielRosenwasser
Copy link
Member

4.9.1-beta is the new version. 😩

@DanielRosenwasser DanielRosenwasser mentioned this issue Sep 23, 2022
Closed
@DanielRosenwasser DanielRosenwasser added this to the TypeScript 4.9.1 milestone Sep 24, 2022
@DanielRosenwasser DanielRosenwasser added Bug A bug in TypeScript Infrastructure Issue relates to TypeScript team infrastructure labels Sep 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DanielRosenwasser DanielRosenwasser

Labels
Bug A bug in TypeScript Infrastructure Issue relates to TypeScript team infrastructure
Projects
None yet
Milestone
TypeScript 4.9.1
Development

Successfully merging a pull request may close this issue.

Use paths in package.json 'files' array that work with npm 6 and later. microsoft/TypeScript
4 participants
@OliverJAsh @DanielRosenwasser @fatcerberus @RyanCavanaugh