Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support inlay hint parts #50236

Closed
mjbvz opened this issue Aug 9, 2022 · 1 comment
Closed

Support inlay hint parts #50236

mjbvz opened this issue Aug 9, 2022 · 1 comment

Comments

@mjbvz
Copy link
Contributor

mjbvz commented Aug 9, 2022

From microsoft/vscode#129528

Search terms

  • inlay hint
  • Symbol

Feature request

VS Code's inlay hints now support parts:

https://github.com/microsoft/vscode/blob/1a500916671d65ee24484c3fca41a9cd243dd54f/src/vscode-dts/vscode.d.ts#L4848

This allows users to interact with individual works within the inlay hint. For JS/TS, we should use this for type inlay hints to allow the user to click into specific types

For example, if the inlay hint is : a | b, there would be four parts:

  1. :
  2. a — And clicking on it should go to the symbol a
  3. |
  4. b — And clicking on it should go to the symbol b

These parts can be resolved lazily too if computing them in the original request is too expensive

@mjbvz
Copy link
Contributor Author

mjbvz commented Aug 10, 2022

Actually this is already tracked by #47693

@mjbvz mjbvz closed this as completed Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant