Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicit type annotation required in TS 4.5 #47384

Open
mikearnaldi opened this issue Jan 11, 2022 · 3 comments
Open

Explicit type annotation required in TS 4.5 #47384

mikearnaldi opened this issue Jan 11, 2022 · 3 comments
Assignees
Labels
Needs Investigation This issue needs a team member to investigate its status.

Comments

@mikearnaldi
Copy link

Bug Report

I am sorry to report a bug in this way without a minimized repro but I wasn't able to minimise it, I'd be happy to do more in debugging it but I'd need some pointers.

🔎 Search Terms

explicit type annotation, 4.5 issues

🕗 Version & Regression Information

This was introduced in 4.5, it's not yet fixed in next and is working fine up to 4.4

💻 Code

Effect-Deprecated/monocle@401ff6b#diff-05996f2c5b1dbbe79e34a0167eb2ee5017f540f68dd1f94e16cc9760ff3aabacR171

🙁 Actual behavior

Screenshot 2022-01-11 104517

🙂 Expected behavior

to compile fine, there are no two types named F, when explicitly annotated like in the commit above the compiler can check the type correctly.

Screenshot 2022-01-11 104634

@RyanCavanaugh RyanCavanaugh added the Needs More Info The issue still hasn't been fully clarified label Jan 11, 2022
@RyanCavanaugh
Copy link
Member

11 type parameters 👀👀

We'll need a reduced repro to investigate this.

@mikearnaldi
Copy link
Author

11 type parameters 👀👀

We'll need a reduced repro to investigate this.

As mentioned I am having trouble minimizing it, any pointer / gut feeling on what could be generating this kind of errors (that is thinking multiple types exist with the same name) to help me minimizing it?

@Andarist
Copy link
Contributor

Andarist commented Mar 12, 2022

@RyanCavanaugh I got a reproduced test case:
TS playground 4.4 (working)
TS playground 4.5 (not working)

The reported error is somewhat different than the one in the given repository but I got this thing by reducing that referenced commit so I think it's highly related issue/the same issue.

I've also bisected the change to this PR. It addresses some perf issues created in this PR so I would say that both are worth taking a look at when investigating this.

EDIT:// This is the last slimmed down version that I have that has the original~ error:
TS playground
and this is the next one that starts reporting the error in the same way as the final slimmed down version:
TS playground

@RyanCavanaugh RyanCavanaugh removed the Needs More Info The issue still hasn't been fully clarified label Mar 14, 2022
@RyanCavanaugh RyanCavanaugh added the Needs Investigation This issue needs a team member to investigate its status. label Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Investigation This issue needs a team member to investigate its status.
Projects
None yet
Development

No branches or pull requests

4 participants