Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve display experience for unresolved symbols #45893

Closed
DanielRosenwasser opened this issue Sep 15, 2021 · 0 comments · Fixed by #45976
Closed

Improve display experience for unresolved symbols #45893

DanielRosenwasser opened this issue Sep 15, 2021 · 0 comments · Fixed by #45976
Assignees
Labels
Domain: Type Display Bugs relating to showing types in Quick Info/Tooltips, Signature Help, or Completion Info Experimentation Needed Someone needs to try this out to see what happens Fix Available A PR has been opened for this issue Suggestion An idea for TypeScript

Comments

@DanielRosenwasser
Copy link
Member

Today if you have code like

function foo(x: Thing) {

}

and Thing is not resolved, quick info will just fill in Thing as any. It may be preferable to still display Thing, which could be achieved by synthesizing a new symbol on the fly. This is handy in partial semantic mode, where full program construction is still taking place in the background, or in scenarios like web editors where we'll never have the full project.

This should not affect declaration emit. Additionally, there's a risk that users find this confusing because it's occasionally useful to know that something is in a broken state. While anys are annoying, they help signal this.

The work involved here might be related to #38836

@DanielRosenwasser DanielRosenwasser added Suggestion An idea for TypeScript Experimentation Needed Someone needs to try this out to see what happens labels Sep 15, 2021
@DanielRosenwasser DanielRosenwasser added this to the TypeScript 4.5.0 milestone Sep 15, 2021
@DanielRosenwasser DanielRosenwasser added the Domain: Type Display Bugs relating to showing types in Quick Info/Tooltips, Signature Help, or Completion Info label Sep 15, 2021
@typescript-bot typescript-bot added the Fix Available A PR has been opened for this issue label Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Domain: Type Display Bugs relating to showing types in Quick Info/Tooltips, Signature Help, or Completion Info Experimentation Needed Someone needs to try this out to see what happens Fix Available A PR has been opened for this issue Suggestion An idea for TypeScript
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants