Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-imports from builder-util-runtime #38176

Closed
s4m0r4m4 opened this issue Mar 26, 2020 · 3 comments
Closed

Auto-imports from builder-util-runtime #38176

s4m0r4m4 opened this issue Mar 26, 2020 · 3 comments
Labels
Duplicate An existing issue was already created

Comments

@s4m0r4m4
Copy link

Hello, thank you for your help! Here's my setup:
Version: 1.43.2 (user setup)
Commit: 0ba0ca52957102ca3527cf479571617f0de6ed50
Date: 2020-03-24T07:38:38.248Z
Electron: 7.1.11
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Windows_NT x64 10.0.14393

Steps to Reproduce:

  1. Make a slim new angular project: ng new <name> --skip-git --minimal . This will setup the angular folder structure and run npm install on its own
  2. Install electron-builder: npm install electron-builder. This will also install an npm package called builder-util-runtime, which exports a class called GenericServerOptions
  3. In app.component.ts (or any .ts file for that matter), try to create a variable and type it as GenericServerOptions: let a: GenericServerOptions;
  4. VS code does not produce auto-import suggestions while I'm typing "GenericServerOptions" (which I would like it to), nor any other exports from that library.
  5. After I finish typing, VS code (rightly) red underlines "GenericServerOptions" with an error message "Cannot find name ....". When I do "Ctrl+." on that erorr, there are no code actions available.
  6. Auto-imports and code fixes work for libraries like rxjs, but not for other libraries like electron-builder.

Does this issue occur when all extensions are disabled?: Yes sir

@mjbvz mjbvz self-assigned this Mar 26, 2020
@mjbvz mjbvz transferred this issue from microsoft/vscode Apr 25, 2020
@mjbvz
Copy link
Contributor

mjbvz commented Apr 25, 2020

This seemed by-design due to #32517

However, even after adding an explicit dependency in my package.json for builder-util-runtime I still don't see suggestions. This seems like #37812

@mjbvz mjbvz removed their assignment Apr 25, 2020
@DanielRosenwasser DanielRosenwasser added the Duplicate An existing issue was already created label Apr 27, 2020
@typescript-bot
Copy link
Collaborator

This issue has been marked as a 'Duplicate' and has seen no recent activity. It has been automatically closed for house-keeping purposes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Duplicate An existing issue was already created
Projects
None yet
Development

No branches or pull requests

4 participants