Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move perfLogger startup statement to TSServer startup #33246

Closed
andrewbranch opened this issue Sep 4, 2019 · 1 comment · Fixed by #34551
Closed

Move perfLogger startup statement to TSServer startup #33246

andrewbranch opened this issue Sep 4, 2019 · 1 comment · Fixed by #34551
Assignees
Labels
Bug A bug in TypeScript

Comments

@andrewbranch
Copy link
Member

See #33141 /cc @mrcrane

@mrcrane
Copy link
Contributor

mrcrane commented Oct 18, 2019

After some investigation I see that this statement is redundant anyway, and can be removed.

We are logging this information for TS Server here:

logger.info(`Arguments: ${process.argv.join(" ")}`);

And the Logger class has already been instrumented to pass Logger.info messages to the perfLogger:

perfLogger.logInfoEvent(s);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A bug in TypeScript
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants