-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggestion: Export some internal type checking helpers #19602
Comments
Duplicate of #9879 |
@mhegazy Thanks for the pointing! Closing |
@raveclassic and anybody else looking at type checking saga yield calls: I've create a very crude custom tslint rule here. The rules checks that the return type of the function passed to It's not perfect, but it works for my needs, hope it helps. |
@cloudify Thanks! However we've dropped both redux and redux-saga and switched to rxjs completely. |
I'm trying to implement a tslint custom rule to manually force and check yield typings inside of generator-based sagas from redux-saga. As the statuses of #2983 and similar issues are unknown it seems like custom rule is the only way for now.
So, at the moment I'm able to only force setting explicit type on the left side of yield expression:
The next step is to extract the types of the left and right sides of such yield and it's possible with public
TypeChecker#getTypeFromTypeNode
.Now when both types are available they could be checked for assignability with helpers under
// TYPE CHECKING
section incompiler/checker.ts
increateTypechecker
factory function (likecheckTypeAssignableTo
), but unfortunately they are isolated inside that factory.Therefore I suggest exporting that helpers from
compiler/checker.ts
on the module-level (or under a namespace, or even asTypeChecker
static fields), they will be very helpful for implementing such custom rules.The text was updated successfully, but these errors were encountered: