Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: add config excludeTypes #17242

Closed
k8w opened this issue Jul 17, 2017 · 2 comments
Closed

Suggestion: add config excludeTypes #17242

k8w opened this issue Jul 17, 2017 · 2 comments
Labels
Duplicate An existing issue was already created

Comments

@k8w
Copy link

k8w commented Jul 17, 2017

TypeScript Version: 2.4.0 / nightly (2.5.0-dev.201xxxxx)
2.4.0

Code

This is a frontend project.

let timer: number = setTimeout(()=>{}, 1000);
npm i @types/protobufjs

Expected behavior:
Compile success

Actual behavior:
Compile error for type of timer not match that in @types/node

@types/node is a dependency that @types/protobufjs need.
But in frontend project, it always be brought by some lib (maybe can run both at browser and server)

Need some way to exclude @types/node for frontend project.

So suggest this:

{
  ..
  excludeTypes: ['@types/node']
}
@ikatyang
Copy link
Contributor

It seems duplicate of #17042?

@ikatyang ikatyang marked this as a duplicate of #17042 Jul 17, 2017
@mhegazy mhegazy added the Duplicate An existing issue was already created label Aug 23, 2017
@mhegazy
Copy link
Contributor

mhegazy commented Sep 7, 2017

Automatically closing this issue for housekeeping purposes. The issue labels indicate that it is unactionable at the moment or has already been addressed.

@mhegazy mhegazy closed this as completed Sep 7, 2017
@microsoft microsoft locked and limited conversation to collaborators Jun 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Duplicate An existing issue was already created
Projects
None yet
Development

No branches or pull requests

3 participants