getApplicableRefactors taking a long time

[ghost]

The log from microsoft/vscode#30449 (comment) shows that getApplicableRefactors can take a long time after a small change has been made to one file. The tsserver log doesn't tell us much about what is taking the time -- we could add deeper logging to help investigate.
CC @RyanCavanaugh

[billti]

What's the latest with this? Does VS Code need this fix so they can reenable the refactorings they had to disable via the 1.14.1 recovery build? cc @mjbvz

[ghost]

It's still not certain that getApplicableRefactors was actually to blame; something else might have been going on. It would be nice to have functionality to turn that on and off so users could test if that was causing the problem for them.
Linking #17269 since that might be related to apparent performance problems too.

[mjbvz]

We re-enabled the refactorings in VS Codes insiders builds and have not seen any further CPU usage issues reported. If there is still any concern about this feature in TS 2.4, we could always gate it to ts 2.5 on the VSCode side

[mhegazy]

Discussing this offline today with @andy-ms and @mjbvz, we do not believe this is related to refactoring. closing for now, please open a new issue if there are perf degradation and we will investigate.