Excess object literals property checking fails when the literal includes a spread

[sandersn]

Excess object literal property checking fails when the literal includes a spread.

let x = { b: 1, extra: 2 }
let xx: { a, b }  = { a: 1, ...x, z: 3 } // error for 'z', no error for 'extra'

Actual: No Error

Expected:
Error for 'z', no error for 'extra'

[sandersn]

Probably checkObjectLiteral needs to set ObjectLiteral and FreshObjectLiteral flags on the result of getSpreadType (if the result is an object type — if it's a type parameter then freshness wouldn't apply anyway).

[mhegazy]

We discussed this in #12997, and decided it worked as intended. what changed?

[sandersn]

I just forgot when we noticed it again on Friday afternoon. On the surface it looks like an oversight.

[wclr]

let x = { b: 1, extra: 2 }
let xx: { a, b }  = { a: 1, ...x, z: 3 } // error for 'z', no error for 'extra'

I see currenlty no error in 2.3 (march) for z was that fixed?

And I also don't get why there should not be an error for extra if we are trying to assign it to {a, b}

[sandersn]

@whitecolor See the last section #12997 for discussion.

[wclr]

So it will be fixed, but in 2.4?

[mhegazy]

yes.