Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color theme breaks in .TS files if HTML contains tags that do not require closing #309

Closed
aeschli opened this issue Oct 11, 2016 · 3 comments

Comments

@aeschli
Copy link

aeschli commented Oct 11, 2016

From @Nikki1993 on October 11, 2016 8:1

  • VSCode Version: 1.6
  • OS Version: 10.12

Steps to Reproduce:

  1. Setup an Angular 2.0 project
  2. In the template add hr tag.
  3. Watch as no theme color applied unless break is added to the ending of hr tag which is not required

Non-working color with hr tag as it is http://d.pr/i/auGg

screen shot 2016-10-11 at 10 57 51

Working color with hr tag closed/removed https://d.pr/RG9c#

screen shot 2016-10-11 at 10 58 01

Default or custom theme, both break.

Copied from original issue: microsoft/vscode#13478

@aeschli
Copy link
Author

aeschli commented Oct 11, 2016

@Nikki1993 Can you add the code snippet that shows the problem?

@sheetalkamat
Copy link
Member

@Nikki1993 this doesn't look like TypeScript grammar issue. We do not scope out the template strings from angular into html syntax. Do you have any other extensions installed?

@Nikki1993
Copy link

@aeschli @sheetalkamat

Issue has been fixed by removing the atom javascript extension and downloading latest beta https://marketplace.visualstudio.com/items?itemName=ms-vscode.typescript-javascript-grammar

Everything works as intended now. Thank you!

P.S. would be nice if you could take a look at this as well, microsoft/vscode#13414

@mhegazy mhegazy closed this as completed Oct 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants