Skip to content
This repository has been archived by the owner on Oct 12, 2022. It is now read-only.

Update React & Webpack for webpack 2 #462

Closed
DanielFallon opened this issue Dec 22, 2016 · 7 comments
Closed

Update React & Webpack for webpack 2 #462

DanielFallon opened this issue Dec 22, 2016 · 7 comments
Assignees

Comments

@DanielFallon
Copy link

Couple of things coming up:

  • Webpack 2 is on the horizon (we're at RC 2)
  • awesome-ts-loader is in pretty bad disrepair with the breaking changes from both webpack 2 and ts 2.1.*

Should we return this documentation to using ts-loader? for simple projects, the configuration is much easier, and the simplicity of that loader plugin means that its more likely to stay up to date long term.

Thoughts?
I'll start working on changes and a pull request sometime this weekend

DJF

@mhegazy
Copy link
Contributor

mhegazy commented Dec 22, 2016

@DanielRosenwasser thoughts?

@DanielRosenwasser
Copy link
Member

@TheLarkInn thoughts?

In my opinion, if ts-loader is Webpack 2-ready, ts-loader it is.

@chicoxyzzy
Copy link

It should be mentioned that code splitting with dynamic imports is currently unavailable microsoft/TypeScript#12364

@DanielFallon
Copy link
Author

just to clarify @chicoxyzzy, that's a deficiency of the typescript syntax right now.

As a result, at-loader would be unable to handle this correct?

also a large portion of why I wanted to move back to ts-loader was because it just appears to be better maintained.

  • CI build for awesome-typescript-loader/master has been broken for about 2 months
  • The unit tests don't appear to reflect the currently documented API
  • and there aren't a lot of contributors. ts-loader, in contrast, appears to be a fairly thin shim and has multiple significant contributors.

@chicoxyzzy
Copy link

chicoxyzzy commented Dec 26, 2016

It was just a side note. Both ts-loader and at-loader can't handle this because it is syntax error in TS. It should be clear that not all features of Webpack 2 are available with current version of TypeScript. This will prevent future misunderstanding. So if documentation will be updated for Webpack 2 it seems legit to add note about dynamic imports

@mbertram
Copy link
Contributor

@orta I think this can be closed. The tutorial was updated for a current webpack version (#765).

@orta
Copy link
Contributor

orta commented Jun 26, 2019

Great, thanks @mbertram

@orta orta closed this as completed Jun 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants