Skip to content
This repository has been archived by the owner on Oct 12, 2022. It is now read-only.

Update Ambient Module section in modules.md #236

Open
unional opened this issue Apr 9, 2016 · 3 comments
Open

Update Ambient Module section in modules.md #236

unional opened this issue Apr 9, 2016 · 3 comments
Labels

Comments

@unional
Copy link

unional commented Apr 9, 2016

This section under Ambient Module should be removed:

... We could define each module in its own .d.ts file with top-level export declarations, but it’s more convenient to write them as one larger .d.ts file. To do so, we use a construct similar to ambient namespaces, but we use the module keyword and the quoted name of the module which will be available to a later import

This will prohibit renaming at consumption and create conflict when there are two versions of the package is in used.

Related to:
microsoft/TypeScript#7398

See example on how it will fail:
https://github.com/typings/typings/blob/master/docs/external-modules.md

@DanielRosenwasser
Copy link
Member

The entire section sort of needs a rewrite. I'll admit that I unfortunately haven't gotten the chance to really take a look at #185, but the work should be done there.

@unional
Copy link
Author

unional commented Apr 9, 2016

That's a big rewrite. 😄

@unional
Copy link
Author

unional commented Apr 9, 2016

Collaborative editing markdown is much easier on hackpad then through PR. 😛

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants