Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify in docs that SEAL_BUILD_SEAL_C builds shared library by default #284

Closed
sloede opened this issue Feb 19, 2021 · 1 comment
Closed

Comments

@sloede
Copy link

sloede commented Feb 19, 2021

I tried for a while to build the C interface as a shared library, providing -DSEAL_BUILD_SEAL_C=ON -DBUILD_SHARED_LIBS=ON, only to get an error message from CMake that BUILD_SHARED_LIBS is not allowed when building the C interface:

SEAL/CMakeLists.txt

Lines 437 to 439 in 5c586e2

if(BUILD_SHARED_LIBS)
message(FATAL_ERROR "SEAL_C requires `BUILD_SHARED_LIBS=OFF`")
endif()

Almost ready to give up, I thankfully realized that by default the C interface is already built as a shared library 🙈 To spare future users the same mistakes I made, I suggest to clarify in the README that when building the C interface, a shared library is created by default.

@kimlaine
Copy link
Contributor

Thanks for pointing this out; sorry it was unclear. We'll address this in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants