Skip to content
This repository has been archived by the owner on Jan 12, 2024. It is now read-only.

API discussion on auto emulation rewrite step #424

Closed
msoeken opened this issue Mar 3, 2021 · 3 comments
Closed

API discussion on auto emulation rewrite step #424

msoeken opened this issue Mar 3, 2021 · 3 comments
Labels
Area-API Issue concerns the API design of a library, such as style guide or design principles adherence. Kind-Discussion Used to mark issues that are primarily intended for discussion topics

Comments

@msoeken
Copy link
Member

msoeken commented Mar 3, 2021

The auto emulation feature (microsoft/qsharp-runtime#514) requires a new public attribute, currently called

@EmulateWith("Alternative", "Simulator")
operation Op() : ...

to express that Op should be executed as Alternative when run in Simulator.

This issue should enable discussions on the API for this PR.
@msoeken msoeken added Area-API Issue concerns the API design of a library, such as style guide or design principles adherence. Kind-Discussion Used to mark issues that are primarily intended for discussion topics Status-NeedsApiReview This PR requires an API review before merging in. labels Mar 3, 2021
@cgranade
Copy link
Contributor

cgranade commented Mar 3, 2021

Thanks for opening this, @msoeken! It looks from microsoft/qsharp-runtime#514 like the new attribute would be in the Microsoft.Quantum.Core namespace, is that correct?

@msoeken
Copy link
Member Author

msoeken commented Mar 4, 2021

Yes, that is correct.

@cgranade
Copy link
Contributor

cgranade commented Mar 9, 2021

As per #426, this has been approved modulo the changes discussed in that review. Thanks for driving this!

@cgranade cgranade removed the Status-NeedsApiReview This PR requires an API review before merging in. label Mar 9, 2021
@msoeken msoeken closed this as completed Mar 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Area-API Issue concerns the API design of a library, such as style guide or design principles adherence. Kind-Discussion Used to mark issues that are primarily intended for discussion topics
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cgranade @msoeken